Unified Diff: templates/default.tmpl
Issue 29335113:
Issue 2675 - Implemented responsive header for web.eyeo.com (Closed)
Patch Set: Minor code style and variable scope cleanup
Created Feb. 29, 2016, 5:03 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« static/js/scripts.js ('K')
|
« static/js/scripts.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: templates/default.tmpl |
| diff --git a/templates/default.tmpl b/templates/default.tmpl |
| index f98327e2770d7b9a1110267ae50cdf3e6089cb42..bcea03b872346b884f80a418d77de8280f26c7d9 100644 |
| --- a/templates/default.tmpl |
| +++ b/templates/default.tmpl |
| @@ -15,6 +15,11 @@ |
| <link rel="stylesheet" href="/css/styles.css" type="text/css" media="all"> |
| + <!--[if lt IE 9]> |
| + <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"></script> |
| + <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script> |
|
saroyanm
2016/04/08 16:56:10
I think you would like to get both files from our
juliandoucette
2016/04/25 19:08:56
Good catch.
|
| + <![endif]--> |
| + |
| <script src="/js/jquery.js"></script> |
| <script src="/js/scripts.js"></script> |
| @@ -27,27 +32,69 @@ |
| <body id="top" class="home page page-template-default apollo_validation_on cover wpb-js-composer js-comp-ver-3.6.14.1 vc_responsive"> |
| - <header id="header"> |
| + <header id="header" class="top"> |
| <div class="content-block"> |
| - <a id="logo" href="{{source.resolve_link("index", locale)[1]}}" hreflang="{{source.resolve_link("index", locale)[0]}}" title="Eyeo GmbH" rel="home"><img src="/images/tog_logo.png" alt="Eyeo GmbH" /></a> |
| - <nav id="menu" role="navigation"> |
| - <h3 class="assistive-text">Main menu</h3> |
| - <a class="assistive-text" href="#begin-of-content">Skip to primary content</a> |
| - <a class="assistive-text" href="#secondary">Skip to secondary content</a> |
| + <a |
|
saroyanm
2016/04/08 16:56:10
While we do have 80 line limit for coding style we
juliandoucette
2016/04/25 19:08:56
Sorry, I thought it was easier to read this way.
saroyanm
2016/05/06 14:49:28
Currently how it's done it's inconsistent, you hav
juliandoucette
2016/05/11 18:11:06
Agreed. Will do.
|
| + id="logo" |
| + href="{{source.resolve_link("index", locale)[1]}}" |
| + hreflang="{{source.resolve_link("index", locale)[0]}}" |
| + title="Eyeo GmbH" rel="home"> |
| + <img src="/images/tog_logo.png" height="51px" alt="Eyeo GmbH" /> |
| + </a> |
| - <a href="{{source.resolve_link("jobs", locale)[1]}}" hreflang="{{source.resolve_link("jobs", locale)[0]}}" class="menu-button">Join us - we are hiring!</a> |
| + <a |
|
saroyanm
2016/05/06 14:49:28
I can't understand why we have this element and th
juliandoucette
2016/05/11 18:11:06
Providing a "skip to content" link is a standard a
juliandoucette
2016/05/11 18:41:27
Scratch that. I actually just removed one and fixe
|
| + class="assistive-text" |
| + href="#begin-of-content"> |
| + Skip to primary content |
| + </a> |
| + <a |
| + class="assistive-text" |
| + href="#secondary"> |
| + Skip to secondary content |
| + </a> |
| + <button type="button" id="header-hamberger" aria-expanded="false"> |
| + <span class="assistive-text">Toggle navigation</span> |
| + <span class="icon-bar"></span> |
| + <span class="icon-bar"></span> |
| + <span class="icon-bar"></span> |
| + </button> |
| + |
| + <a |
| + href="{{source.resolve_link("jobs", locale)[1]}}" |
| + hreflang="{{source.resolve_link("jobs", locale)[0]}}" |
| + class="menu-button"> |
| + Join us - we are hiring! |
| + </a> |
| + |
| + <nav |
| + id="menu" |
| + role="navigation" |
| + aria-labelledby="header-hamberger" |
| + aria-expanded="false"> |
| + <h3 class="assistive-text">Main menu</h3> |
| <ul class="menu-list"> |
| {%- for link, title in [("index", "About Us"), ("services", "Services"), ("team", "Team"), ("press", "Press"), ("contact", "Contact Us")] %} |
| {%- if link == page %} |
| - <li class="menu-item menu-item-type-post_type menu-item-object-page current-menu-item page_item current_page_item">{{link|linkify}}<span>{{title}}</span></a></li> |
| + <li |
| + class="menu-item menu-item-type-post_type menu-item-object-page current-menu-item page_item current_page_item"> |
| + {{link|linkify}} |
| + <span>{{title}}</span> |
| + </a> |
| + </li> |
| {%- else %} |
| - <li class="menu-item menu-item-type-post_type menu-item-object-page">{{link|linkify}}<span>{{title}}</span></a></li> |
| + <li |
| + class="menu-item menu-item-type-post_type menu-item-object-page"> |
| + {{link|linkify}} |
| + <span>{{title}}</span> |
| + </a> |
| + </li> |
| {%- endif %} |
| {%- endfor %} |
| </ul> |
| </nav> |
| + |
| </div> |
| </header> |
« static/js/scripts.js ('K')
|
« static/js/scripts.js ('k')
|
no next file »
|
no next file with comments »
