Unified Diff: templates/default.tmpl
Issue 29335113:
Issue 2675 - Implemented responsive header for web.eyeo.com (Closed)
Patch Set: Implemented scripts in vanilla.js
Created May 11, 2016, 11:25 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« static/js/scripts.js ('K')
|
« static/js/scripts.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: templates/default.tmpl |
| =================================================================== |
| --- a/templates/default.tmpl |
| +++ b/templates/default.tmpl |
| @@ -10,49 +10,76 @@ |
| {% else %} |
| <title>Eyeo GmbH</title> |
| {% endif %} |
| <link rel="shortcut icon" href="/images/favicon.png" /> |
| <link rel="stylesheet" href="/css/styles.css" type="text/css" media="all"> |
| + <!--[if lt IE 9]> |
| + <script src="/static/js/html5shiv.min.js"></script> |
| + <script src="/static/js/respond.min.js"></script> |
| + <![endif]--> |
| + |
| <script src="/js/jquery.js"></script> |
| <script src="/js/scripts.js"></script> |
| <link rel="canonical" href="https://eyeo.com/{{ page[:-5] if page.split('/')[-1] == 'index' else page }}"> |
| {% block head %} |
| {{head|safe}} |
| {% endblock %} |
| </head> |
| <body id="top" class="home page page-template-default apollo_validation_on cover wpb-js-composer js-comp-ver-3.6.14.1 vc_responsive"> |
| - <header id="header"> |
| + <header id="header" class="top"> |
| <div class="content-block"> |
| - <a id="logo" href="{{source.resolve_link("index", locale)[1]}}" hreflang="{{source.resolve_link("index", locale)[0]}}" title="Eyeo GmbH" rel="home"><img src="/images/tog_logo.png" alt="Eyeo GmbH" /></a> |
| - <nav id="menu" role="navigation"> |
| - <h3 class="assistive-text">Main menu</h3> |
| - <a class="assistive-text" href="#begin-of-content">Skip to primary content</a> |
| - <a class="assistive-text" href="#secondary">Skip to secondary content</a> |
| + <a id="logo" href="{{source.resolve_link("index", locale)[1]}}" hreflang="{{source.resolve_link("index", locale)[0]}}" title="Eyeo GmbH" rel="home"> |
| + <img src="/images/tog_logo.png" height="51px" alt="Eyeo GmbH" /> |
|
saroyanm
2016/05/19 07:43:41
Detail: I assume we had misspelled beforehand, top
juliandoucette
2016/05/19 12:01:45
Yes.
I'll correct it though.
saroyanm
2016/05/23 12:39:21
I made a comment regarding high DPI screens here:
juliandoucette
2016/06/16 18:07:45
Done. I added a srcset attribute that specifies an
saroyanm
2016/06/22 07:54:18
I like this solution!
|
| + </a> |
| - <a href="{{source.resolve_link("jobs", locale)[1]}}" hreflang="{{source.resolve_link("jobs", locale)[0]}}" class="menu-button">Join us - we are hiring!</a> |
| + <a class="assistive-text" href="#content"> |
| + Skip to main content |
| + </a> |
| + <button type="button" id="header-hamberger" aria-expanded="false"> |
|
saroyanm
2016/05/19 07:43:41
Hamburger also should belong to the navigation as
juliandoucette
2016/05/19 12:01:45
About the _skip to content_ link:
I disagree beca
saroyanm
2016/05/23 12:39:21
Thanks for detailed explanation I think you are ri
|
| + <span class="assistive-text">Toggle navigation</span> |
| + <span class="icon-bar"></span> |
| + <span class="icon-bar"></span> |
| + <span class="icon-bar"></span> |
| + </button> |
| + |
| + <a href="{{source.resolve_link("jobs", locale)[1]}}" hreflang="{{source.resolve_link("jobs", locale)[0]}}" class="menu-button"> |
| + Join us - we are hiring! |
| + </a> |
| + |
| + <nav id="menu" role="navigation" aria-labelledby="header-hamberger" aria-expanded="false"> |
| + <h1 class="assistive-text">Main menu</h1> |
| <ul class="menu-list"> |
| {%- for link, title in [("index", "About Us"), ("services", "Services"), ("team", "Team"), ("press", "Press"), ("contact", "Contact Us")] %} |
| {%- if link == page %} |
| - <li class="menu-item menu-item-type-post_type menu-item-object-page current-menu-item page_item current_page_item">{{link|linkify}}<span>{{title}}</span></a></li> |
| + <li class="menu-item menu-item-type-post_type menu-item-object-page current-menu-item page_item current_page_item"> |
|
saroyanm
2016/05/19 07:43:41
Feels like only "current-menu-item" class is being
juliandoucette
2016/05/19 12:01:45
A WordPress artifact, no doubt.
I'll check and re
juliandoucette
2016/06/16 18:07:45
Done.
|
| + {{link|linkify}} |
| + <span>{{title}}</span> |
| + </a> |
| + </li> |
| {%- else %} |
| - <li class="menu-item menu-item-type-post_type menu-item-object-page">{{link|linkify}}<span>{{title}}</span></a></li> |
| + <li class="menu-item menu-item-type-post_type menu-item-object-page"> |
| + {{link|linkify}} |
| + <span>{{title}}</span> |
| + </a> |
| + </li> |
| {%- endif %} |
| {%- endfor %} |
| </ul> |
| </nav> |
| + |
| </div> |
| </header> |
| <div id="content"> |
| {{body|safe}} |
| </div> |
| <footer id="footer"> |
« static/js/scripts.js ('K')
|
« static/js/scripts.js ('k')
|
no next file »
|
no next file with comments »
