Issue 29335261: Issue 154 - Adapted for change replacing isFrameWhitelisted with checkWhitelisted

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29335261: Issue 154 - Adapted for change replacing isFrameWhitelisted with checkWhitelisted (Closed)

Created:
Feb. 2, 2016, 11:31 a.m. by Sebastian Noack

Modified:
Feb. 2, 2016, 1:19 p.m.

Reviewers:
Thomas Greiner

CC:
kzar

Visibility:
Public.

Description

With the related changes for the devtools panel in adblockpluschrome, isFrameWhitelisted(page, frame[, type]) and isPageWhitelisted(page) are gone, and got superseded by checkWhitelisted(page[, frame [,type]]). This change needs to be accounted for in the message responder.

Patch Set 1 #

Created: Feb. 2, 2016, 11:31 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	messageResponder.js	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages