Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 29335388: Issue 3616 - Turn popupBlocker.js into a module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Sebastian Noack
Modified:
3 years, 6 months ago
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3616 - Turn popupBlocker.js into a module

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M lib/popupBlocker.js View 2 chunks +52 lines, -49 lines 1 comment Download
M metadata.common View 2 chunks +1 line, -1 line 0 comments Download
M metadata.safari View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
3 years, 6 months ago (2016-02-02 18:26:16 UTC) #1
kzar
3 years, 6 months ago (2016-02-03 10:18:15 UTC) #2
Otherwise LGTM

https://codereview.adblockplus.org/29335388/diff/29335389/lib/popupBlocker.js
File lib/popupBlocker.js (right):

https://codereview.adblockplus.org/29335388/diff/29335389/lib/popupBlocker.js...
lib/popupBlocker.js:70: checkPotentialPopup(details.tabId, details.url,
sourcePage, documentHost, specificOnly);
Nit: Mind fixing the long lines too?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5