Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29335437: Issue 3620 - Make "Block element" generate domain specific filters when $genericblock is active (Closed)

Created:
Feb. 3, 2016, 10:25 a.m. by Sebastian Noack
Modified:
Feb. 3, 2016, 5:41 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3620 - Make "Block element" generate domain specific filters when $genericblock is active

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M lib/filterComposer.js View 2 chunks +5 lines, -1 line 1 comment Download

Messages

Total messages: 2
Sebastian Noack
Feb. 3, 2016, 10:26 a.m. (2016-02-03 10:26:29 UTC) #1
kzar
Feb. 3, 2016, 10:29 a.m. (2016-02-03 10:29:41 UTC) #2
Otherwise LGTM

https://codereview.adblockplus.org/29335437/diff/29335438/lib/filterComposer.js
File lib/filterComposer.js (right):

https://codereview.adblockplus.org/29335437/diff/29335438/lib/filterComposer....
lib/filterComposer.js:99: let specificOnly = checkWhitelisted(page, frame,
RegExpFilter.typeMap.GENERICBLOCK);
Nit: Long line

Powered by Google App Engine
This is Rietveld