Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 29335668: Issue 2597 - Begin the switch to adblockpluscore (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by kzar
Modified:
3 years, 9 months ago
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2597 - Begin the switch to adblockpluscore

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Keep adblockplus dependency for those pesky strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M dependencies View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M metadata.common View 1 2 3 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 13
kzar
Patch Set 1
3 years, 10 months ago (2016-02-04 19:02:17 UTC) #1
kzar
(Note: I've not synchronised these "new" strings with Crowdin. I've not looked too closely that ...
3 years, 10 months ago (2016-02-04 19:35:34 UTC) #2
Sebastian Noack
The translations added (copied from adblockplus) fall into following categories: 1. The product name 2. ...
3 years, 10 months ago (2016-02-05 11:39:31 UTC) #3
kzar
On 2016/02/05 11:39:31, Sebastian Noack wrote: > ... So you either you have to do ...
3 years, 10 months ago (2016-02-05 12:34:35 UTC) #4
kzar
https://codereview.adblockplus.org/29335668/diff/29335669/_locales/en_US/messages.json File _locales/en_US/messages.json (left): https://codereview.adblockplus.org/29335668/diff/29335669/_locales/en_US/messages.json#oldcode199 _locales/en_US/messages.json:199: "invalid_css_selector": { On 2016/02/05 11:39:30, Sebastian Noack wrote: > ...
3 years, 10 months ago (2016-02-05 12:34:52 UTC) #5
Felix Dahlke
On 2016/02/05 11:39:31, Sebastian Noack wrote: > However, I'm not sure whether it's a good ...
3 years, 10 months ago (2016-02-05 15:38:45 UTC) #6
Sebastian Noack
On 2016/02/05 15:38:45, Felix Dahlke wrote: > I might be missing something, but I cannot ...
3 years, 10 months ago (2016-02-05 15:45:31 UTC) #7
Felix Dahlke
On 2016/02/05 15:45:31, Sebastian Noack wrote: > On 2016/02/05 15:38:45, Felix Dahlke wrote: > > ...
3 years, 10 months ago (2016-02-05 16:25:05 UTC) #8
kzar
On 2016/02/05 16:25:05, Felix Dahlke wrote: > To sum up the discussion on IRC (including ...
3 years, 10 months ago (2016-02-05 21:06:50 UTC) #9
Sebastian Noack
We need a short time solution here. Further delaying dependency updates isn't an option. Duplicating ...
3 years, 9 months ago (2016-02-15 17:57:53 UTC) #10
kzar
On 2016/02/15 17:57:53, Sebastian Noack wrote: > We need a short time solution here. Further ...
3 years, 9 months ago (2016-02-15 18:05:09 UTC) #11
kzar
Patch Set 2 : Rebased Patch Set 3 : Keep adblockplus dependency for those pesky ...
3 years, 9 months ago (2016-02-15 18:31:41 UTC) #12
Sebastian Noack
3 years, 9 months ago (2016-02-15 18:37:49 UTC) #13
Thanks! LGTM

You might want to update the title of the review and the respective commit
message though. It's no longer accurate.

Can also somebody please file follow-up issues for the changes discussed above
and for finally removing the adblockplus dependency here?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5