Issue 2426 - Open block.html as a popup window

safari/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 204 matching lines @@
 
   var isPageActive = function(page)
   {
     var tab = page._tab;
     var win = tab.browserWindow;
     return win && tab == win.activeTab && page == tab._visiblePage;
   };
 
   var forgetPage = function(id)
   {
+    ext.pages.onRemoved._dispatch(id);
+
     ext._removeFromAllPageMaps(id);
 
     delete pages[id]._tab._pages[id];
     delete pages[id];
   };
 
   var replacePage = function(page)
   {
     var tab = page._tab;
     tab._visiblePage = page;
@@ skipping 63 matching lines @@
         if ("lastFocusedWindow" in info && info.lastFocusedWindow != (win == safari.application.activeBrowserWindow))
           continue;
 
         matchedPages.push(page);
       };
 
       callback(matchedPages);
     },
     onLoading: new ext._EventTarget(),
     onActivated: new ext._EventTarget(),
+    onRemoved: new ext._EventTarget()
   };
 
   safari.application.addEventListener("close", function(event)
   {
     // this event is dispatched on closing windows and tabs. However when a
     // window is closed, it is first dispatched on each tab in the window and
     // then on the window itself. But we are only interested in closed tabs.
     if (!(event.target instanceof SafariBrowserTab))
       return;
 
@@ skipping 429 matching lines @@
       {
         tab.activate();
         if (callback)
           callback(page);
         return;
       }
     }
 
     ext.pages.open(optionsUrl, callback);
   };
+
+  /* Windows */
+  ext.windows = {
+    // Safari doesn't provide as rich a windows API as Chrome does, so instead
+    // of chrome.windows.create we have to fall back to just opening a new tab.
+    create: function(createData, callback)
+    {
+      if (createData && createData.url)

[Sebastian Noack, 2016/02/10 12:26:57]

Just assume the URL to be given? If it's missing, not doing anything, isn't the
expected result and inconsistent with Chrome.

[kzar, 2016/02/10 14:20:17]

Done.

+        ext.pages.open(createData.url, callback);
+    }
+  };
 })();