Issue 2426 - Open block.html as a popup window

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 41 matching lines @@
     }
   };
 
   ext.getPage = function(id)
   {
     return new Page({id: parseInt(id, 10)});
   };
 
   function afterTabLoaded(callback)
   {
-    if (callback)
-    {
-      return function(openedTab)
-      {
-        var onUpdated = function(tabId, changeInfo, tab)
-        {
-          if (tabId == openedTab.id && changeInfo.status == "complete")
-          {
-            chrome.tabs.onUpdated.removeListener(onUpdated);
-            callback(new Page(openedTab));
-          }
-        };
-        chrome.tabs.onUpdated.addListener(onUpdated);
-      };
-    }
+     return function(openedTab)
+     {
+       var onUpdated = function(tabId, changeInfo, tab)
+       {
+         if (tabId == openedTab.id && changeInfo.status == "complete")
+         {
+           chrome.tabs.onUpdated.removeListener(onUpdated);
+           callback(new Page(openedTab));
+         }
+       };
+       chrome.tabs.onUpdated.addListener(onUpdated);
+     };
   }
 
   ext.pages = {
     open: function(url, callback)
     {
-      chrome.tabs.create({url: url}, afterTabLoaded(callback));

[Sebastian Noack, 2016/02/12 17:00:00]

I'd rather check here for the callback:

  callback && afterTabLoaded(callback)

That way we avoid one more block in afterTabLoaded() and in the function below
we assume the callback to be given anyway.

[kzar, 2016/02/13 14:18:12]

Done.

+      chrome.tabs.create({url: url}, callback && afterTabLoaded(callback));
     },
     query: function(info, callback)
     {
       var rawInfo = {};
       for (var property in info)
       {
         switch (property)
         {
           case "active":
           case "lastFocusedWindow":
@@ skipping 504 matching lines @@
   ext.windows = {
     create: function(createData, callback)
     {
       chrome.windows.create(createData, function(createdWindow)
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 })();