Issue 2426 - Open block.html as a popup window

safari/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 747 matching lines @@
 
     ext.pages.open(optionsUrl, callback);
   };
 
   /* Windows */
   ext.windows = {
     // Safari doesn't provide as rich a windows API as Chrome does, so instead
     // of chrome.windows.create we have to fall back to just opening a new tab.
     create: function(createData, callback)
     {
-      if (createData)

[Sebastian Noack, 2016/02/17 20:44:06]

I'd simply assume that createData is given and has an URL. Note that the
behavior when createData is missing is inconsistent with Chrome anyway. On
Chrome this will open an empty window. But no reason, to cover a case that we
don't have.

Otherwise, LGTM. Feel free to push, after removing the check, here.

[kzar, 2016/02/17 20:52:21]

Done.

-        ext.pages.open(createData.url, callback);
+      ext.pages.open(createData.url, callback);
     }
   };
 })();