Unified Diff: lib/devtools.js
Issue 29336084:
Issue 2426 - Open block.html as a popup window (Closed)
Patch Set: Pass tab directly instead of getTab callback
Created Feb. 11, 2016, 3:19 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« chrome/ext/background.js ('K')
|
« include.postload.js ('k')
|
lib/icon.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/devtools.js |
| diff --git a/lib/devtools.js b/lib/devtools.js |
| index c94cced25c2cf5b5544c933dd1caf6fc0ab6e558..76b887b0481ba0e5b0fcd15f78ab12b603887b83 100644 |
| --- a/lib/devtools.js |
| +++ b/lib/devtools.js |
| @@ -37,7 +37,7 @@ function hasPanels() |
| function getActivePanel(page) |
| { |
| - let panel = panels[page._id]; |
| + let panel = panels[page.id]; |
| if(panel && !panel.reload && !panel.reloading) |
| return panel; |
| return null; |
| @@ -210,7 +210,7 @@ exports.logWhitelistedDocument = function(page, url, typeMask, docDomain, filter |
| */ |
| exports.hasPanel = function(page) |
| { |
| - return page._id in panels; |
| + return page.id in panels; |
| }; |
| function onBeforeRequest(details) |
| @@ -239,7 +239,7 @@ function onBeforeRequest(details) |
| function onLoading(page) |
| { |
| - let tabId = page._id; |
| + let tabId = page.id; |
| let panel = panels[tabId]; |
| // Reloading the tab is the only way that allows bypassing all caches, in |
« chrome/ext/background.js ('K')
|
« include.postload.js ('k')
|
lib/icon.js » ('j')
|
no next file with comments »
