ext/background.js - Issue 29336084: Issue 2426 - Open block.html as a popup window

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/background.js

Issue 29336084: Issue 2426 - Open block.html as a popup window (Closed)

Patch Set: Check callback exists outside of afterTabLoaded Created Feb. 13, 2016, 2:16 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/background.js

diff --git a/ext/background.js b/ext/background.js

index 55ca943f7093a4387d7e6af13bf8fa228250f3e4..f6ce8ce075bae22f0569a1cdd741ee29646ba580 100644

--- a/ext/background.js

+++ b/ext/background.js

@@ -35,20 +35,20 @@

keys: function()

{

- return Object.keys(this._map).map(ext._getPage);

+ return Object.keys(this._map).map(ext.getPage);

get: function(page)

{

- return this._map[page._id];

+ return this._map[page.id];

set: function(page, value)

{

- this._map[page._id] = value;

+ this._map[page.id] = value;

nonEmptyPageMaps[this._id] = this;

has: function(page)

{

- return page._id in this._map;

+ return page.id in this._map;

clear: function()

{

@@ -57,7 +57,7 @@

delete: function(page)

{

- this._delete(page._id);

+ this._delete(page.id);

}

};