Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/icon.js

Issue 29336084: Issue 2426 - Open block.html as a popup window (Closed)
Patch Set: Check callback exists outside of afterTabLoaded Created Feb. 13, 2016, 2:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/icon.js
diff --git a/lib/icon.js b/lib/icon.js
index e9c96c3bf11694e3f512b925d62c9c16188fb2d7..5b4db79da6945eec0418f01edab3b81962870201 100644
--- a/lib/icon.js
+++ b/lib/icon.js
@@ -64,7 +64,7 @@ function setIcon(page, notificationType, opacity, frames)
else
{
chrome.browserAction.setIcon({
- tabId: page._id,
+ tabId: page.id,
imageData: frames["" + opacity + whitelisted]
});
}
« chrome/ext/background.js ('K') | « lib/devtools.js ('k') | metadata.chrome » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld