Issue 3649 - Truncate notificationDownloadCount

lib/uninstall.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 12 matching lines @@
 
 function setUninstallURL()
 {
   let search = [];
   let keys = ["addonName", "addonVersion", "application", "applicationVersion",
               "platform", "platformVersion"];
   for (let key of keys)
     search.push(key + "=" + encodeURIComponent(info[key]));
 
   let downlCount = Prefs.notificationdata.downloadCount || 0;
-  if (typeof(downlCount) == "number" && downlCount > 3)

[Sebastian Noack, 2016/02/11 14:31:24]

In the downloader module, it's only truncated above 4. So it can still be 4, but
5 or any larger value becomes 4+.

[Sebastian Noack, 2016/02/11 14:31:24]

Nit: Mind adding a comment that this code is matter to be removed once
https://issues.adblockplus.org/ticket/3650 has been implemented (and the
dependency has been updated).

[Sebastian Noack, 2016/02/11 14:31:24]

Nit: typeof is a keyword not a function, so please no parenthesis.

[kzar, 2016/02/11 14:45:20]

Done.

[kzar, 2016/02/11 14:45:20]

Done.

[kzar, 2016/02/11 14:45:20]

Acknowledged.

+
+  // FIXME - Once the changes for issue #3650 land and are included we should
+  //         remove this check. (The number will be already truncated for us.)
+  if (downlCount > 4)
     downlCount = "4+";
+
   search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));
 
   chrome.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" +
                                  search.join("&"));
 }
 
 // The uninstall URL contains the notification download count as a parameter,
 // therefore we must wait for preferences to be loaded before generating the
 // URL and we need to re-generate it each time the notification data changes.
 if ("setUninstallURL" in chrome.runtime)
 {
   Prefs.isLoaded.then(setUninstallURL);
   Prefs.onChanged.addListener(function(name)
   {
     if (name == "notificationdata")
       setUninstallURL();
   });
 }