lib/uninstall.js - Issue 29336255: Issue 3649 - Truncate notificationDownloadCount

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/uninstall.js

Issue 29336255: Issue 3649 - Truncate notificationDownloadCount (Closed)

Patch Set: Created Feb. 11, 2016, 2:24 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/uninstall.js

diff --git a/lib/uninstall.js b/lib/uninstall.js

index 3872e1cde76860e697cb24fb44005e182ddbfeef..8faab512063f2fec4ee047ccb881c88921c731f7 100644

--- a/lib/uninstall.js

+++ b/lib/uninstall.js

@@ -30,6 +30,8 @@ function setUninstallURL()

search.push(key + "=" + encodeURIComponent(info[key]));

let downlCount = Prefs.notificationdata.downloadCount || 0;

+ if (typeof(downlCount) == "number" && downlCount > 3)

Sebastian Noack 2016/02/11 14:31:24 In the downloader module, it's only truncated abov

Sebastian Noack 2016/02/11 14:31:24 Nit: Mind adding a comment that this code is matte

Sebastian Noack 2016/02/11 14:31:24 Nit: typeof is a keyword not a function, so please

kzar 2016/02/11 14:45:20 Done.

kzar 2016/02/11 14:45:20 Acknowledged.

+ downlCount = "4+";

search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));

chrome.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" +

« no previous file with comments | « no previous file | no next file » | no next file with comments »