Delta Between Two Patch Sets: options.html
Issue 29336364:
issue 2377 - Finish design of Advanced tab of new options page (Closed)
Left Patch Set: Rebase to changeset 72
Created April 8, 2016, 3:12 p.m.
Right Patch Set:
Created April 28, 2016, 1 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« locale/en-US/options.json ('k')
|
skin/options.css » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2016 Eyeo GmbH | 4 - Copyright (C) 2006-2016 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 237 <label> | 237 <label> |
| 238 <button role="checkbox" data-action="toggle-pref"></button> | 238 <button role="checkbox" data-action="toggle-pref"></button> |
| 239 <span class="i18n_options_tweaks_safariContentBlocker"></span> | 239 <span class="i18n_options_tweaks_safariContentBlocker"></span> |
| 240 </label> | 240 </label> |
| 241 <span id="restart-safari" class="i18n_options_tweaks_restartSafa ri"></span> | 241 <span id="restart-safari" class="i18n_options_tweaks_restartSafa ri"></span> |
| 242 </li> | 242 </li> |
| 243 </ul> | 243 </ul> |
| 244 </div> | 244 </div> |
| 245 | 245 |
| 246 <div> | 246 <div> |
| 247 <h1 class="with-description"> | 247 <h1> |
|
Thomas Greiner
2016/04/18 18:32:51
Why do you need this class? All it seems to be use
saroyanm
2016/04/20 14:28:58
I used to align the content inside inline, for rea
| |
| 248 <span class="i18n_options_filterList_title"></span> | 248 <span class="i18n_options_filterList_title"></span> |
| 249 <div class="tooltip"> | 249 <div class="tooltip"> |
| 250 <span class="i18n_options_readMore"></span> | 250 <span class="i18n_options_readMore"></span> |
| 251 <div role="tooltip"> | 251 <div role="tooltip"> |
| 252 <p class="i18n_options_filterList_title_tooltip"></p> | 252 <p class="i18n_options_filterList_title_tooltip"></p> |
| 253 <div class="notes"> | 253 <div class="notes"> |
| 254 <p class="i18n_options_filterList_title_tooltip_notes_1"></p > | 254 <p class="i18n_options_filterList_title_tooltip_notes_1"></p > |
| 255 <p class="i18n_options_filterList_title_tooltip_notes_2"></p > | 255 <p class="i18n_options_filterList_title_tooltip_notes_2"></p > |
| 256 </div> | 256 </div> |
| 257 </div> | 257 </div> |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 281 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a> | 281 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a> |
| 282 </div> | 282 </div> |
| 283 </div> | 283 </div> |
| 284 </div> | 284 </div> |
| 285 </div> | 285 </div> |
| 286 <span class="date"></span> | 286 <span class="date"></span> |
| 287 <span class="time"></span> | 287 <span class="time"></span> |
| 288 <span class="message"></span> | 288 <span class="message"></span> |
| 289 </template> | 289 </template> |
| 290 <li class="static"> | 290 <li class="static"> |
| 291 <button role="checkbox" class="control" aria-checked="true" disabled="true"></button> | 291 <button id="own-list" role="checkbox" class="control" aria-c hecked="true" disabled="true"></button> |
| 292 <div> | 292 <div> |
| 293 <strong class="i18n_options_filterList_own_list"></strong> | 293 <label for="own-list" class="i18n_options_filterList_own_l ist"></label> |
|
Thomas Greiner
2016/04/18 18:32:51
Detail: For accessibility reasons, I'd suggest tha
saroyanm
2016/04/20 14:28:58
Done.
| |
| 294 </div> | 294 </div> |
| 295 <span data-action="switch-tab,edit-custom-filters" data-tab= "advanced-customFilters"> | 295 <span data-action="switch-tab,edit-custom-filters" data-tab= "advanced-customFilters"> |
| 296 <a class="i18n_options_filterList_edit_own_list"></a> | 296 <a class="i18n_options_filterList_edit_own_list"></a> |
| 297 </span> | 297 </span> |
| 298 </li> | 298 </li> |
| 299 </ul> | 299 </ul> |
| 300 <div class="controls"> | 300 <div class="controls"> |
| 301 <button data-action="open-dialog" data-dialog="custom"> | 301 <button data-action="open-dialog" data-dialog="custom"> |
| 302 <span class="icon icon-add"></span> | 302 <span class="icon icon-add"></span> |
| 303 <span class="i18n_options_filterList_add"></span> | 303 <span class="i18n_options_filterList_add"></span> |
| 304 </button> | 304 </button> |
| 305 <button data-action="update-all-subscriptions"> | 305 <button data-action="update-all-subscriptions"> |
| 306 <span class="icon icon-update"></span> | 306 <span class="icon icon-update"></span> |
| 307 <span class="i18n_options_filterList_update"></span> | 307 <span class="i18n_options_filterList_update"></span> |
| 308 </button> | 308 </button> |
| 309 </div> | 309 </div> |
| 310 </div> | 310 </div> |
| 311 <div id="custom-filters"> | 311 <div id="custom-filters"> |
| 312 <h2 id="custom-filters-header" class="with-description"> | 312 <h2 id="custom-filters-header"> |
| 313 <span class="i18n_options_customFilters_title"></span> | 313 <span class="i18n_options_customFilters_title"></span> |
| 314 <div class="tooltip"> | 314 <div class="tooltip"> |
| 315 <span class="i18n_options_readMore"></span> | 315 <span class="i18n_options_readMore"></span> |
| 316 <div role="tooltip"> | 316 <div role="tooltip"> |
| 317 <p class="i18n_options_customFilters_title_tooltip"></p> | 317 <p class="i18n_options_customFilters_title_tooltip"></p> |
| 318 </div> | 318 </div> |
| 319 </div> | 319 </div> |
| 320 </h2> | 320 </h2> |
| 321 <div id="custom-filters-wrapper"> | 321 <div id="custom-filters-wrapper"> |
| 322 <div id="custom-filters-list-wrapper"> | 322 <div id="custom-filters-list-wrapper"> |
| (...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 433 <div class="url"></div> | 433 <div class="url"></div> |
| 434 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 434 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 435 </div> | 435 </div> |
| 436 </div> | 436 </div> |
| 437 </div> | 437 </div> |
| 438 <!-- Placeholder element to determine when to wrap focus around --> | 438 <!-- Placeholder element to determine when to wrap focus around --> |
| 439 <span class="focus-last" tabindex="0"></span> | 439 <span class="focus-last" tabindex="0"></span> |
| 440 </div> | 440 </div> |
| 441 </body> | 441 </body> |
| 442 </html> | 442 </html> |
| LEFT | RIGHT |
« locale/en-US/options.json ('k')
|
skin/options.css » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
