issue 2377 - Finish design of Advanced tab of new options page

skin/options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 282 matching lines @@
 #tab-share[hidden] + li
 {
   border-top: none;
 }
 
 #content
 {
   background-color: #FFFFFF;
   border: 1px solid #CDCDCD;
   border-radius: 8px;
-  box-sizing: border-box;
-  min-width: 960px;
+  width: 840px;
   padding: 0px 60px 40px 60px;
 }
 
 #content h1
 {
   border-bottom: 1px solid #CDCDCD;
   margin: 0px 0px 24px 0px;
   padding: 40px 0px 16px 0px;
 }
 
@@ skipping 477 matching lines @@
   -webkit-margin-end: 6px;
   -moz-margin-end: 6px;
   -webkit-margin-start: 12px;
   -moz-margin-start: 12px;
   background-position: -20px -49px;
 }
 
 #all-filter-lists-table .static label
 {
   font-weight: 600;
-}
-
-#custom-filters
-{
-  width: 838px;

[Thomas Greiner, 2016/04/28 10:48:44]

This is a workaround.

1. According to
https://issues.adblockplus.org/attachment/ticket/1526/options_page_styleguide...
the content's inner width should be `840px` (i.e. `900-2*60`). That is excluding
borders.

2. The width should be defined by the content element. So I looked into possible
solutions and found this to work best:

#content
{
-  min-width: 960px;
+  width: 960px;
}

It's still debateable whether we should use `960px` or `962px` due to the border
width - unlike in the style guide - being included in the width calculation of
the box model.

Note that I'm not sure why we've been using "min-width" in the first place.

[saroyanm, 2016/04/28 13:16:23]

Yes, true, Done.
Done.
Yes you are right it's bit tricky with the design example, I kept it 962px for
now, otherwise we should change paddings, or content should be 838. 

 }
 
 #custom-filters-header
 {
   padding: 0px 16px;
   margin-bottom: 10px;
 }
 
 #custom-filters-raw-controls
 {
@@ skipping 514 matching lines @@
 #other-language .button-add::before
 {
   display: none;
 }
 
 #other-language .display
 {
   -webkit-margin-start: 10px;
   -moz-margin-start: 10px;
 }