Unified Diff: options.html
Issue 29336364:
issue 2377 - Finish design of Advanced tab of new options page (Closed)
Patch Set:
Created Feb. 15, 2016, 12:29 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« locale/en-US/options.json ('K')
|
« locale/en-US/options.json ('k')
|
skin/options.css » ('j')
|
skin/options.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.html |
| =================================================================== |
| --- a/options.html |
| +++ b/options.html |
| @@ -213,11 +213,8 @@ |
| <!-- Advanced tab content --> |
| <div id="content-advanced" class="tab-content"> |
| <div> |
| - <h1> |
| - <span class="i18n_options_tweaks_title"></span> |
| - <a class="i18n_options_readMore tooltip"></a> |
| - </h1> |
| - <ul class="table"> |
| + <h1 class="i18n_options_tweaks_title"></h1> |
| + <ul id="tweaks" class="table"> |
| <li> |
| <button role="checkbox" id="easylist"></button> |
| <span id="block-element-explanation" class="i18n_options_tweaks_blockElement"></span> |
| @@ -225,9 +222,18 @@ |
| </ul> |
| </div> |
| <div> |
| - <h1> |
| + <h1 class="with-description"> |
| <span class="i18n_options_filterList_title"></span> |
| - <a class="i18n_options_readMore tooltip"></a> |
| + <div class="tooltip"> |
| + <span class="i18n_options_readMore"></span> |
| + <div role="tooltip"> |
| + <p class="i18n_options_filterList_title_tooltip"></p> |
| + <div class="notes"> |
| + <p class="i18n_options_filterList_title_tooltip_notes_1"></p> |
| + <p class="i18n_options_filterList_title_tooltip_notes_2"></p> |
| + </div> |
| + </div> |
| + </div> |
| </h1> |
| <ul class="tabs horizontal"> |
| <li class="i18n_options_tab_overview active" data-action="switch-tab" data-tab="advanced-allFilterLists"></li> |
| @@ -259,7 +265,7 @@ |
| <span class="time"></span> |
| <span class="message"></span> |
| </template> |
| - <li class="static"> |
| + <li id="own-filter-list" class="static"> |
| <button role="checkbox" class="control" aria-checked="true" disabled="true"></button> |
| <div> |
| <span class="i18n_options_filterList_own_list"></span> |
| @@ -281,7 +287,15 @@ |
| </div> |
| </div> |
| <div id="custom-filters"> |
| - <h3 id="custom-filters-header" class="i18n_options_customFilters_title"></h3> |
| + <h3 id="custom-filters-header" class="with-description"> |
| + <span class="i18n_options_customFilters_title"></span> |
| + <div class="tooltip"> |
| + <span class="i18n_options_readMore"></span> |
| + <div role="tooltip"> |
| + <p class="i18n_options_customFilters_title_tooltip"></p> |
| + </div> |
| + </div> |
| + </h3> |
| <div id="custom-filters-wrapper"> |
| <div id="custom-filters-list-wrapper"> |
| <ul id="custom-filters-table" class="table list"> |
| @@ -302,14 +316,14 @@ |
| <span class="i18n_options_customFilter_edit"></span> |
| </button> |
| <div id="custom-filters-raw-controls"> |
| + <button id="custom-filters-raw-save" data-action="save-custom-filters"> |
| + <span class="icon icon-cancel"></span> |
| + <span class="i18n_options_customFilter_save"></span> |
|
Thomas Greiner
2016/02/15 18:09:21
Detail: You're using "icon-cancel" and "i18n_optio
saroyanm
2016/02/24 11:23:57
Oops, thanks.
|
| + </button> |
| <button data-action="cancel-custom-filters"> |
| - <span class="icon icon-edit"></span> |
| + <span class="icon icon-save"></span> |
| <span class="i18n_options_customFilter_list"></span> |
| </button> |
| - <button id="custom-filters-raw-save" data-action="save-custom-filters"> |
| - <span class="icon icon-edit"></span> |
| - <span class="i18n_options_customFilter_save"></span> |
| - </button> |
| </div> |
| </div> |
| </div> |
« locale/en-US/options.json ('K')
|
« locale/en-US/options.json ('k')
|
skin/options.css » ('j')
|
skin/options.css » ('J')
