Issue 29336406: Issue 3654 - Properly split up selectors when applying CSS property filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29336406: Issue 3654 - Properly split up selectors when applying CSS property filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 6 months ago by Sebastian Noack

Modified:
3 years, 6 months ago

Reviewers:
kzar

CC:
Wladimir Palant, Thomas Greiner

Visibility:
Public.

More Reviews

Description

Issue 3654 - Properly split up selectors when applying CSS property filters

Patch Set 2 : Undid unrelated whitespace change #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -1 line)			Patch
	M	chrome/content/cssProperties.js	View	1	2 chunks	+43 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sebastian Noack

https://codereview.adblockplus.org/29336406/diff/29336407/chrome/content/cssProperties.js File chrome/content/cssProperties.js (right): https://codereview.adblockplus.org/29336406/diff/29336407/chrome/content/cssProperties.js#newcode1 chrome/content/cssProperties.js:1: function splitSelector(selector) This logic has been copied (with some ...

3 years, 6 months ago (2016-02-15 17:19:08 UTC) #1

kzar

LGTM https://codereview.adblockplus.org/29336406/diff/29336407/chrome/content/cssProperties.js File chrome/content/cssProperties.js (right): https://codereview.adblockplus.org/29336406/diff/29336407/chrome/content/cssProperties.js#newcode1 chrome/content/cssProperties.js:1: function splitSelector(selector) On 2016/02/15 17:19:08, Sebastian Noack wrote: ...

3 years, 6 months ago (2016-02-15 17:30:14 UTC) #2

Sebastian Noack

3 years, 6 months ago (2016-02-15 17:49:31 UTC) #3

https://codereview.adblockplus.org/29336406/diff/29336407/chrome/content/cssP...
File chrome/content/cssProperties.js (right):

https://codereview.adblockplus.org/29336406/diff/29336407/chrome/content/cssP...
chrome/content/cssProperties.js:1: function splitSelector(selector)
On 2016/02/15 17:30:14, kzar wrote:
> On 2016/02/15 17:19:08, Sebastian Noack wrote:
> > This logic has been copied (with some minor changes) from
> > adblockpluschrome/include.perload.js. After the dependency update we should
> > reuse splitSelector() there.
> 
> Acknowledged. (Mind filing an issue for that?)

I attached the patch the same issue:
https://codereview.adblockplus.org/29336409/

Expand All Messages | Collapse All Messages