Issue 29336491: Issue 3660 - Remove locale dependency from subscription classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29336491: Issue 3660 - Remove locale dependency from subscription classes (Closed)

Created:
Feb. 16, 2016, 12:23 p.m. by Wladimir Palant

Modified:
Feb. 22, 2016, 10:36 p.m.

Reviewers:
same66768, Thomas Greiner

CC:
Erik

Visibility:
Public.

Description

Actually dropped some more dependencies here: 1) Instead of doing a full URL check the custom filter lists are recognized by URLs starting with ~ 2) Removed upgradeRequired field, this check should be performed in the UI 3) Removed special treatment for legacy groups like ~fl~, nobody is going to upgrade from eight years old versions The unit test has been migrated without changes except for the ~fl~ check (title should no longer be present)

Patch Set 1 #

Created: Feb. 16, 2016, 12:23 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -51 lines)			Patch
	M	lib/subscriptionClasses.js	View		6 chunks	+6 lines, -51 lines	0 comments	Download
	A	test/subscriptionClasses.js	View		1 chunk	+87 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

same66768

Feb. 22, 2016, 10:36 p.m. (2016-02-22 22:36:12 UTC) #3

Message was sent while issue was closed.

On 2016/02/19 17:30:39, Thomas Greiner wrote:
> LGTM

Expand All Messages | Collapse All Messages