Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29336525: Issue 3584 - Work around WebKit uppercase ID matching bug (Closed)

Created:
Feb. 16, 2016, 7:43 p.m. by kzar
Modified:
Feb. 17, 2016, 4:02 p.m.
Reviewers:
Sebastian Noack
CC:
dean
Visibility:
Public.

Description

Issue 3584 - Work around WebKit uppercase ID matching bug

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use [id="Whatever"] syntax #

Total comments: 2

Patch Set 3 : Don't forget IDs at the end of the string #

Total comments: 13

Patch Set 4 : Addressed more feedback #

Total comments: 6

Patch Set 5 : Addressed nit I missed before #

Patch Set 6 : Addressed further feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M abp2blocklist.js View 1 2 3 4 5 2 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 10
kzar
Patch Set 1
Feb. 16, 2016, 7:48 p.m. (2016-02-16 19:48:24 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29336525/diff/29336526/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29336525/diff/29336526/abp2blocklist.js#newcode296 abp2blocklist.js:296: // FIXME - Hack to work around WebKit bug ...
Feb. 17, 2016, 8:04 a.m. (2016-02-17 08:04:29 UTC) #2
kzar
Patch Set 2 : Use [id="Whatever"] syntax https://codereview.adblockplus.org/29336525/diff/29336526/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29336525/diff/29336526/abp2blocklist.js#newcode296 abp2blocklist.js:296: // FIXME ...
Feb. 17, 2016, 1:45 p.m. (2016-02-17 13:45:26 UTC) #3
kzar
Patch Set 3 : Don't forget IDs at the end of the string
Feb. 17, 2016, 2:06 p.m. (2016-02-17 14:06:47 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29336525/diff/29336528/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29336525/diff/29336528/abp2blocklist.js#newcode283 abp2blocklist.js:283: else if (chr < "0" && chr != "-" ...
Feb. 17, 2016, 2:22 p.m. (2016-02-17 14:22:20 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29336525/diff/29336530/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29336525/diff/29336530/abp2blocklist.js#newcode257 abp2blocklist.js:257: function attributeSyntaxForIDs(selector) Perhaps a better name for this function: ...
Feb. 17, 2016, 2:41 p.m. (2016-02-17 14:41:00 UTC) #6
kzar
Patch Set 4 : Addressed more feedback https://codereview.adblockplus.org/29336525/diff/29336530/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29336525/diff/29336530/abp2blocklist.js#newcode257 abp2blocklist.js:257: function attributeSyntaxForIDs(selector) ...
Feb. 17, 2016, 3:13 p.m. (2016-02-17 15:13:52 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29336525/diff/29336532/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29336525/diff/29336532/abp2blocklist.js#newcode269 abp2blocklist.js:269: else if (chr == sep) // don't split within ...
Feb. 17, 2016, 3:24 p.m. (2016-02-17 15:24:37 UTC) #8
kzar
Patch Set 5 : Addressed nit I missed before Patch Set 6 : Addressed further ...
Feb. 17, 2016, 3:35 p.m. (2016-02-17 15:35:04 UTC) #9
Sebastian Noack
Feb. 17, 2016, 3:56 p.m. (2016-02-17 15:56:38 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld