Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29336582: Issue 2813 - Catch missing sitescripts module and return empty list on adblockplus.org (Closed)

Created:
Feb. 18, 2016, 11:03 a.m. by juliandoucette
Modified:
Feb. 25, 2016, 2:53 p.m.
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 2813 - Catch missing sitescripts module and return empty list on adblockplus.org

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed error name and added logging message #

Total comments: 2

Patch Set 3 : Added empty line to improve reading flow #

Total comments: 2

Patch Set 4 : Added line break to warning message #

Total comments: 2

Patch Set 5 : Fixed warning string spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M filters/get_subscriptions.py View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 13
juliandoucette
Feb. 18, 2016, 11:05 a.m. (2016-02-18 11:05:50 UTC) #1
kzar
When you publish a patch set it's useful to paste the name (like "Patch Set ...
Feb. 18, 2016, 3:24 p.m. (2016-02-18 15:24:25 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29336582/diff/29336583/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29336583/filters/get_subscriptions.py#newcode25 filters/get_subscriptions.py:25: except ImportError as error: On 2016/02/18 15:24:25, kzar wrote: ...
Feb. 19, 2016, 5 p.m. (2016-02-19 17:00:11 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29336582/diff/29336708/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29336708/filters/get_subscriptions.py#newcode28 filters/get_subscriptions.py:28: return [] Nit: An empty line below would improve ...
Feb. 19, 2016, 5:10 p.m. (2016-02-19 17:10:18 UTC) #4
juliandoucette
https://codereview.adblockplus.org/29336582/diff/29336708/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29336708/filters/get_subscriptions.py#newcode28 filters/get_subscriptions.py:28: return [] On 2016/02/19 17:10:18, Sebastian Noack wrote: > ...
Feb. 19, 2016, 5:25 p.m. (2016-02-19 17:25:16 UTC) #5
kzar
https://codereview.adblockplus.org/29336582/diff/29336733/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29336733/filters/get_subscriptions.py#newcode27 filters/get_subscriptions.py:27: logging.warning("Unable to import sitescripts, proceeding with empty subscriptions list") ...
Feb. 19, 2016, 5:57 p.m. (2016-02-19 17:57:14 UTC) #6
juliandoucette
https://codereview.adblockplus.org/29336582/diff/29336733/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29336733/filters/get_subscriptions.py#newcode27 filters/get_subscriptions.py:27: logging.warning("Unable to import sitescripts, proceeding with empty subscriptions list") ...
Feb. 23, 2016, 2:50 p.m. (2016-02-23 14:50:27 UTC) #7
kzar
https://codereview.adblockplus.org/29336582/diff/29337551/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29337551/filters/get_subscriptions.py#newcode28 filters/get_subscriptions.py:28: "subscriptions list.") Nit: The indentation here looks wrong, the ...
Feb. 23, 2016, 3:01 p.m. (2016-02-23 15:01:39 UTC) #8
juliandoucette
https://codereview.adblockplus.org/29336582/diff/29337551/filters/get_subscriptions.py File filters/get_subscriptions.py (right): https://codereview.adblockplus.org/29336582/diff/29337551/filters/get_subscriptions.py#newcode28 filters/get_subscriptions.py:28: "subscriptions list.") On 2016/02/23 15:01:38, kzar wrote: > Nit: ...
Feb. 23, 2016, 3:08 p.m. (2016-02-23 15:08:12 UTC) #9
kzar
LGTM
Feb. 23, 2016, 3:24 p.m. (2016-02-23 15:24:02 UTC) #10
Sebastian Noack
LGTM
Feb. 23, 2016, 4:48 p.m. (2016-02-23 16:48:46 UTC) #11
saroyanm
LGTM
Feb. 24, 2016, 4:28 p.m. (2016-02-24 16:28:00 UTC) #12
juliandoucette
Feb. 25, 2016, 2:53 p.m. (2016-02-25 14:53:35 UTC) #13

Powered by Google App Engine
This is Rietveld