Issue 2813 - Catch missing sitescripts module and return empty list on adblockplus.org

filters/get_subscriptions.py

Index: filters/get_subscriptions.py
diff --git a/filters/get_subscriptions.py b/filters/get_subscriptions.py
index e87459808f6956f4dadbb6eec51d3779cc9f4345..790f98fe468738f7c7494a4d12636a4a7b0169bd 100644
--- a/filters/get_subscriptions.py
+++ b/filters/get_subscriptions.py
@@ -17,10 +17,15 @@ import codecs
 import os
 import tarfile
 import urllib
+import logging
 from ConfigParser import SafeConfigParser
 
 def get_subscriptions(_):
-  from sitescripts.subscriptions import subscriptionParser
+  try:
+    from sitescripts.subscriptions import subscriptionParser
+  except ImportError:
+    logging.warning("Unable to import sitescripts, proceeding with empty subscriptions list")

[kzar, 2016/02/19 17:57:14]

Nit: This line is too long (but I think the message is pretty good), could you
wrap it something like this?

logging.warning("Unable to import sitescripts, proceeding with empty "
                "subscriptions list.")

Note:
 - Plus symbol was omitted deliberately
 - I also added a full stop

[juliandoucette, 2016/02/23 14:50:27]

Done.

+    return []
 
   result = {}
   utf8_reader = codecs.getreader('utf8')