Issue 394 - hit statistics tool data collection (core)

lib/filterStorage.js

Index: lib/filterStorage.js
===================================================================
--- a/lib/filterStorage.js
+++ b/lib/filterStorage.js
@@ -29,6 +29,7 @@
 let {Subscription, SpecialSubscription, ExternalSubscription} = require("subscriptionClasses");
 let {FilterNotifier} = require("filterNotifier");
 let {Utils} = require("utils");
+let {FilterHits} = require("filterHits");

[Wladimir Palant, 2016/02/29 14:40:30]

Same here, you cannot expect this module to be present.

[saroyanm, 2016/03/18 18:24:47]

Done.

 
 /**
  * Version number of the filter storage file format.
@@ -323,14 +324,17 @@
   /**
    * Increases the hit count for a filter by one
    * @param {Filter} filter
+   * @param {String} hostname of top window where the match originated in
    */
-  increaseHitCount: function(filter)
+  increaseHitCount: function(filter, hostname)
   {
     if (!Prefs.savestats || !(filter instanceof ActiveFilter))
       return;
 
     filter.hitCount++;
     filter.lastHit = Date.now();
+    if (Prefs.sendstats)

[saroyanm, 2016/02/19 18:31:35]

Hmm, I think it's make sense to check if the module exists, or move filter hit
statistics to the core as well ? 

[Wladimir Palant, 2016/02/29 14:40:31]

Currently that module has too much Firefox-specific stuff in it to be moved into
core.

+      FilterHits.increaseFilterHits(filter, hostname);
   },
 
   /**