Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .hgignore
Issue
29336753
:
Issue 3671 - Split out contentBlockerList API (Closed)
Patch Set: Addressed feedback, removed some modules
Created Feb. 21, 2016, 11:26 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed feedback, removed some modules
Patch Set 3: Reworked API into ContentBlockerList class and addressed other feedback
Patch Set 4: Addressed more feedback
Patch Set 5: Skip lines only containing whitespace
Patch Set 6: Tweaked line skipping logic and addressed a nit
Patch Set 7: Use Sebastian's regexp suggestion
Patch Set 8: Renamed lib/contentBlockList.js to lib/abp2blocklist.js
Right:
Patch Set 1: None
Patch Set 2: Addressed feedback, removed some modules
Patch Set 3: Reworked API into ContentBlockerList class and addressed other feedback
Patch Set 4: Addressed more feedback
Patch Set 5: Skip lines only containing whitespace
Patch Set 6: Tweaked line skipping logic and addressed a nit
Patch Set 7: Use Sebastian's regexp suggestion
Patch Set 8: Renamed lib/contentBlockList.js to lib/abp2blocklist.js
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
README.md
abp2blocklist.js
adblockplus.js
lib/contentBlockerLists.js
node_modules/filterClasses.js
node_modules/url.js
View unified diff
|
Download patch
« no previous file with comments
|
« .gitignore
('k') |
README.md »
('j') |
abp2blocklist.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
node_modules
1
node_modules
/tldjs
OLD
NEW
« no previous file with comments
|
« .gitignore
('k') |
README.md »
('j') |
abp2blocklist.js »
('J')
Edit Message
Issue 29336753: Issue 3671 - Split out contentBlockerList API (Closed)
Created Feb. 20, 2016, 9:59 p.m. by kzar
Modified Feb. 26, 2016, 4:24 p.m.
Reviewers: Sebastian Noack, Felix Dahlke
Base URL:
Comments: 63
This is Rietveld