Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: node_modules/url.js

Issue 29336753: Issue 3671 - Split out contentBlockerList API (Closed)
Patch Set: Addressed feedback, removed some modules Created Feb. 21, 2016, 11:26 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/contentBlockerLists.js ('K') | « node_modules/filterClasses.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: node_modules/url.js
diff --git a/node_modules/url.js b/node_modules/url.js
new file mode 100644
index 0000000000000000000000000000000000000000..d3c1dbaf7bd79d04cd733e1776903cd9779d6124
--- /dev/null
+++ b/node_modules/url.js
@@ -0,0 +1,22 @@
+/*
Sebastian Noack 2016/02/21 20:34:45 Please correct me if I'm wrong, as I'm not too fam
kzar 2016/02/22 12:28:06 The documentation[1] seems to say that while the l
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/** @module url */
Sebastian Noack 2016/02/21 20:34:45 Since the existence of this module is just an impl
kzar 2016/02/22 12:28:06 Done.
kzar 2016/02/22 12:28:06 Done.
+
+"use strict";
+
+exports.getBaseDomain = hostname => require("tldjs").getDomain(hostname);
Sebastian Noack 2016/02/21 20:34:45 How about a comment that this is mimicking the url
Sebastian Noack 2016/02/21 20:34:45 Nit: exports.getBaseDomain = require("tldjs").getD
kzar 2016/02/22 12:28:06 I did that originally but it didn't work. I've cha
kzar 2016/02/22 12:28:06 Done.
« lib/contentBlockerLists.js ('K') | « node_modules/filterClasses.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld