Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 29336790: Issue 3674 - Add a hg hook that references commits in issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Felix Dahlke
Modified:
3 years, 8 months ago
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 3674 - Add a hg hook that references commits in issues

Patch Set 1 : #

Total comments: 15

Patch Set 2 : Address comments #

Total comments: 12

Patch Set 3 : Address comments #

Patch Set 4 : Don't use RegexObject.match #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M .sitescripts.example View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A sitescripts/hg/bin/update_issues.py View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A sitescripts/hg/template/issue_commit_comment.tmpl View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11
Felix Dahlke
3 years, 8 months ago (2016-02-22 10:59:50 UTC) #1
Wladimir Palant
Philip will be extremely happy about installing yet another Trac plugin ;). I'll look into ...
3 years, 8 months ago (2016-02-22 11:32:33 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29336790/diff/29336797/.sitescripts.example File .sitescripts.example (right): https://codereview.adblockplus.org/29336790/diff/29336797/.sitescripts.example#newcode166 .sitescripts.example:166: trac_xmlrpc_url=https://abpbot:abpbot@issues.adblockplus.org/login/xmlrpc On 2016/02/22 11:32:33, Wladimir Palant wrote: > Shouldn't ...
3 years, 8 months ago (2016-02-22 11:41:37 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29336790/diff/29336797/sitescripts/hg/bin/update_issues.py File sitescripts/hg/bin/update_issues.py (right): https://codereview.adblockplus.org/29336790/diff/29336797/sitescripts/hg/bin/update_issues.py#newcode56 sitescripts/hg/bin/update_issues.py:56: {"_ts": attributes["_ts"], "action": "leave"}) The ridiculous part about this ...
3 years, 8 months ago (2016-02-22 12:02:51 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29336790/diff/29336797/sitescripts/hg/bin/update_issues.py File sitescripts/hg/bin/update_issues.py (right): https://codereview.adblockplus.org/29336790/diff/29336797/sitescripts/hg/bin/update_issues.py#newcode56 sitescripts/hg/bin/update_issues.py:56: {"_ts": attributes["_ts"], "action": "leave"}) Sorry about so many mails, ...
3 years, 8 months ago (2016-02-22 12:06:02 UTC) #5
Felix Dahlke
New patch set is up. https://codereview.adblockplus.org/29336790/diff/29336797/.sitescripts.example File .sitescripts.example (right): https://codereview.adblockplus.org/29336790/diff/29336797/.sitescripts.example#newcode166 .sitescripts.example:166: trac_xmlrpc_url=https://abpbot:abpbot@issues.adblockplus.org/login/xmlrpc On 2016/02/22 11:41:37, ...
3 years, 8 months ago (2016-02-22 20:09:50 UTC) #6
Wladimir Palant
https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py File sitescripts/hg/bin/update_issues.py (right): https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py#newcode33 sitescripts/hg/bin/update_issues.py:33: template = get_template("hg/template/issue_commit_comment.tmpl") I think you need autoescape=False here. ...
3 years, 8 months ago (2016-02-23 10:41:31 UTC) #7
Felix Dahlke
New patch set is up. https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py File sitescripts/hg/bin/update_issues.py (right): https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py#newcode33 sitescripts/hg/bin/update_issues.py:33: template = get_template("hg/template/issue_commit_comment.tmpl") On ...
3 years, 8 months ago (2016-02-23 16:23:00 UTC) #8
Wladimir Palant
https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py File sitescripts/hg/bin/update_issues.py (right): https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py#newcode50 sitescripts/hg/bin/update_issues.py:50: noissue_regex = re.compile(r"noissue\b", re.I) On 2016/02/23 16:22:59, Felix Dahlke ...
3 years, 8 months ago (2016-02-23 21:33:23 UTC) #9
Felix Dahlke
And another patch set. https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py File sitescripts/hg/bin/update_issues.py (right): https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/update_issues.py#newcode50 sitescripts/hg/bin/update_issues.py:50: noissue_regex = re.compile(r"noissue\b", re.I) On ...
3 years, 8 months ago (2016-02-23 21:40:59 UTC) #10
Wladimir Palant
3 years, 8 months ago (2016-02-24 10:13:49 UTC) #11
LGTM

https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/...
File sitescripts/hg/bin/update_issues.py (right):

https://codereview.adblockplus.org/29336790/diff/29337499/sitescripts/hg/bin/...
sitescripts/hg/bin/update_issues.py:50: noissue_regex = re.compile(r"noissue\b",
re.I)
On 2016/02/23 21:40:58, Felix Dahlke wrote:
> Fair enough. Tried to be smart, but this comment thread proves that it's a bad
> idea. Done.

Yes, particularly with the regexp and re.match() not in the same place this is
very confusing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5