Side by Side Diff: options.html
Issue 29337729:
Issue 2374 - Implemented Tweaks section in options page (Closed)
Patch Set:
Created Feb. 25, 2016, 5:50 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« messageResponder.js ('K')
|
« messageResponder.js ('k')
|
options.js » ('j')
|
options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2016 Eyeo GmbH | 4 - Copyright (C) 2006-2016 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 205 <button class="i18n_options_button_cancel cancel-button" dat a-action="cancel-domain-exception"></button> | 205 <button class="i18n_options_button_cancel cancel-button" dat a-action="cancel-domain-exception"></button> |
| 206 </div> | 206 </div> |
| 207 </div> | 207 </div> |
| 208 </div> | 208 </div> |
| 209 </div> | 209 </div> |
| 210 </div> | 210 </div> |
| 211 </div> | 211 </div> |
| 212 | 212 |
| 213 <!-- Advanced tab content --> | 213 <!-- Advanced tab content --> |
| 214 <div id="content-advanced" class="tab-content"> | 214 <div id="content-advanced" class="tab-content"> |
| 215 <div> | 215 <div id="tweaks"> |
| 216 <h1> | 216 <h1> |
| 217 <span class="i18n_options_tweaks_title"></span> | 217 <span class="i18n_options_tweaks_title"></span> |
| 218 <a class="i18n_options_readMore tooltip"></a> | 218 <a class="i18n_options_readMore tooltip"></a> |
| 219 </h1> | 219 </h1> |
| 220 <ul class="table"> | 220 <ul class="table"> |
| 221 <li> | 221 <li> |
| 222 <button role="checkbox" id="easylist"></button> | 222 <button role="checkbox" name="shouldShowBlockElementMenu" data-a ction="toggle-pref"></button> |
|
saroyanm
2016/02/29 14:34:39
Why we are using name attribute here ? I think we
Thomas Greiner
2016/02/29 17:32:43
Done. I thought going with existing attributes whe
saroyanm
2016/03/11 14:55:58
Not exactly what I meant, I meant something like:
Thomas Greiner
2016/03/15 15:39:25
Done.
saroyanm
2016/03/16 10:59:18
Mostly looks good, just small Detail from the comm
Thomas Greiner
2016/03/16 11:14:36
Done.
| |
| 223 <span id="block-element-explanation" class="i18n_options_tweaks_ blockElement"></span> | 223 <span class="i18n_options_tweaks_blockElement"></span> |
| 224 </li> | |
| 225 <li data-optional> | |
| 226 <button role="checkbox" name="notifications_ignoredcategories" d ata-action="toggle-pref"></button> | |
| 227 <span class="i18n_options_tweaks_showNotifications"></span> | |
| 228 </li> | |
| 229 <li data-optional> | |
| 230 <button role="checkbox" name="safari_contentblocker" data-action ="toggle-pref"></button> | |
| 231 <span class="i18n_options_tweaks_safariContentBlocker"></span> | |
| 224 </li> | 232 </li> |
| 225 </ul> | 233 </ul> |
| 226 </div> | 234 </div> |
| 235 | |
|
saroyanm
2016/02/29 14:34:39
Detail: no new row needed here.
Thomas Greiner
2016/02/29 17:32:43
Why not? It visually separates the Tweaks and the
saroyanm
2016/03/11 14:55:58
Looks like we currently only separate the main tab
| |
| 227 <div> | 236 <div> |
| 228 <h1> | 237 <h1> |
| 229 <span class="i18n_options_filterList_title"></span> | 238 <span class="i18n_options_filterList_title"></span> |
| 230 <a class="i18n_options_readMore tooltip"></a> | 239 <a class="i18n_options_readMore tooltip"></a> |
| 231 </h1> | 240 </h1> |
| 232 <ul class="tabs horizontal"> | 241 <ul class="tabs horizontal"> |
| 233 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li> | 242 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li> |
| 234 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li> | 243 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li> |
| 235 </ul> | 244 </ul> |
| 236 <div id="filter-lists"> | 245 <div id="filter-lists"> |
| (...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 397 <div class="url"></div> | 406 <div class="url"></div> |
| 398 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 407 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 399 </div> | 408 </div> |
| 400 </div> | 409 </div> |
| 401 </div> | 410 </div> |
| 402 <!-- Placeholder element to determine when to wrap focus around --> | 411 <!-- Placeholder element to determine when to wrap focus around --> |
| 403 <span class="focus-last" tabindex="0"></span> | 412 <span class="focus-last" tabindex="0"></span> |
| 404 </div> | 413 </div> |
| 405 </body> | 414 </body> |
| 406 </html> | 415 </html> |
| OLD | NEW |
