Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29337729: Issue 2374 - Implemented Tweaks section in options page (Closed)
Left Patch Set: Created Feb. 25, 2016, 5:50 p.m.
Right Patch Set: Created March 16, 2016, 11:13 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | background.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Shared Adblock Plus UI code 1 Shared Adblock Plus UI code
2 =========================== 2 ===========================
3 3
4 The user interface elements defined in this repository will be used by various 4 The user interface elements defined in this repository will be used by various
5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be
6 tested within this repository, even though they might not work exactly the same 6 tested within this repository, even though they might not work exactly the same
7 as they will do in the final product. 7 as they will do in the final product.
8 8
9 Directory structure 9 Directory structure
10 ------------------- 10 -------------------
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 This is the implementation of the Adblock Plus first-run page that will show up 58 This is the implementation of the Adblock Plus first-run page that will show up
59 whenever changes are applied automatically to user's Adblock Plus configuration. 59 whenever changes are applied automatically to user's Adblock Plus configuration.
60 This will usually happen when the user first installs Adblock Plus (initial 60 This will usually happen when the user first installs Adblock Plus (initial
61 setup), but it can also happen in case the user's settings get lost. 61 setup), but it can also happen in case the user's settings get lost.
62 62
63 The behavior of this page is affected by a number of URL parameters: 63 The behavior of this page is affected by a number of URL parameters:
64 64
65 * `platform`, `platformVersion`, `application`, `applicationVersion`: sets 65 * `platform`, `platformVersion`, `application`, `applicationVersion`: sets
66 application parameters that are normally determined by Adblock Plus. Using 66 application parameters that are normally determined by Adblock Plus. Using
67 `?platform=safari&platformVersion=5.0` should trigger a warning. 67 `?platform=safari&platformVersion=5.0` should trigger a warning.
68 * `seenDataCorruption`, `filterlistsReinitialized`: setting these parameters to 68 * `filterlistsReinitialized`: setting these parameters to `true` should
69 `true` should trigger warnings referring to issues detected by Adblock Plus. 69 trigger warnings referring to issues detected by Adblock Plus.
70 * `blockedURLs`: a comma-separated list of URLs that should be considered 70 * `blockedURLs`: a comma-separated list of URLs that should be considered
71 blocked (necessary to test the check for blocked scripts in sharing buttons). 71 blocked (necessary to test the check for blocked scripts in sharing buttons).
72 72
73 options.html 73 options.html
74 ------------ 74 ------------
75 75
76 This is the implementation of the Adblock Plus options page which is the primary 76 This is the implementation of the Adblock Plus options page which is the primary
77 UI for changing settings and for managing filter lists. 77 UI for changing settings and for managing filter lists.
78 78
79 The behavior of this page is affected by a number of URL parameters: 79 The behavior of this page is affected by a number of URL parameters:
80 80
81 * `addonVersion`: sets addon version application parameter that is used for 81 * `addonVersion`: sets addon version application parameter that is used for
82 creating the link to the version-specific release notes 82 creating the link to the version-specific release notes
83 * `addSubscription=true`: this parameter should trigger a dialog for adding 83 * `addSubscription=true`: this parameter should trigger a dialog for adding
84 subscriptions as initiated by clicking on an "abp:subscribe" link 84 subscriptions as initiated by clicking on an "abp:subscribe" link
85 * `filterError=true`: causes filter validation to fail, showing validation 85 * `filterError=true`: causes filter validation to fail, showing validation
86 errors when adding new filters on the options page 86 errors when adding new filters on the options page
87 * `blockedURLs`: a comma-separated list of URLs that should be considered 87 * `blockedURLs`: a comma-separated list of URLs that should be considered
88 blocked (necessary to test the check for blocked scripts in sharing buttons). 88 blocked (necessary to test the check for blocked scripts in sharing buttons).
89 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used 89 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used
90 to trigger various filter list download errors 90 to trigger various filter list download errors
91 * `safariContentBlocker`: sets Safari content blocker mock API 91 * `platform=chromium`: shows the opt-out for the developer tools panel
saroyanm 2016/02/29 14:34:38 Detail: Seems like for boolean parameters we also
Thomas Greiner 2016/02/29 17:32:42 Done. You're right, I missed that.
92 * `showNotificationUI`: simulates user having opted-out of notifications 92 * `safariContentBlocker=true`: sets Safari content blocker mock API
93 * `showNotificationUI=true`: simulates user having opted-out of notifications
93 94
94 95
95 [crowdin]: https://crowdin.com 96 [crowdin]: https://crowdin.com
LEFTRIGHT
« no previous file | background.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld