decisionbot.py - Issue 29337738: Issue 3703 - Add "coin flip" feature to abpbot

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: decisionbot.py

Issue 29337738: Issue 3703 - Add "coin flip" feature to abpbot (Closed)

Left Patch Set: Ensure IRC bot username is at the beginning of a question string Created Feb. 25, 2016, 7:52 p.m.

Right Patch Set: Fixed a couple more nits Created Feb. 25, 2016, 8:50 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/env python

2 # coding: utf-8
Sebastian Noack 2016/02/25 20:09:42 Nit: We recently decided to not use coding declara Nit: We recently decided to not use coding declarations in new code for PEP-8 compliance. kzar 2016/02/25 20:29:51 Done. Show quoted text On 2016/02/25 20:09:42, Sebastian Noack wrote: > Nit: We recently decided to not use coding declarations in new code for PEP-8 > compliance. Done.
3

4 import random
Sebastian Noack 2016/02/25 20:09:42 Nit; also from PEP-8: Imports are always put at th Nit; also from PEP-8: Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. kzar 2016/02/25 20:29:51 Done. Show quoted text On 2016/02/25 20:09:42, Sebastian Noack wrote: > Nit; also from PEP-8: Imports are always put at the top of the file, just after > any module comments and docstrings, and before module globals and constants. Done.
5 import re

6

7 from irclib import nm_to_n

8

9 """	1 """

10 Decisionbot - A simple IRC bot to help make "coin flip" decisions.	2 Decisionbot - A simple IRC bot to help make "coin flip" decisions.

11	3

12 botname: x or y?	4 botname: x or y?

13 => x	5 => x

14	6

15 botname: a or b or c?	7 botname: a or b or c?

16 => b	8 => b

17 """	9 """

18	10

	11 import random

	12 import re

	13

	14 from irclib import nm_to_n

	15

	16

19 class Decisionbot():	17 class Decisionbot():

20 def __init__(self, config, queue):	18 def __init__(self, config, queue):

21 self.queue = queue	19 self.queue = queue

22	20

23 nickname = config.get("main", "nickname")	21 nickname = config.get("main", "nickname")

24 self.question_regexp = re.compile("^%s:?(.+\s+or\s+.+)\?+\s*$" %	22 self.question_regexp = re.compile(r"^%s:?(.+\s+or\s+.+)\?+\s*$" %
Sebastian Noack 2016/02/25 20:09:42 Perhaps we should use the case-insensitive flag fo Perhaps we should use the case-insensitive flag for this regexp. Same below. kzar 2016/02/25 20:29:51 Done. Show quoted text On 2016/02/25 20:09:42, Sebastian Noack wrote: > Perhaps we should use the case-insensitive flag for this regexp. Same below. Done.
25 re.escape(nickname))	23 re.escape(nickname), re.IGNORECASE)

	24 self.question_delim_regexp = re.compile(r"\s+or\s+", re.IGNORECASE)

26	25

27 def on_pubmsg(self, connection, event):	26 def on_pubmsg(self, connection, event):

28 channel = event.target()	27 channel = event.target()

29 message = event.arguments()[0]	28 message = event.arguments()[0]

30 sender = nm_to_n(event.source())	29 sender = nm_to_n(event.source())

31	30

32 match = self.question_regexp.search(message)	31 match = self.question_regexp.search(message)

33 if (match):	32 if (match):

34 choices = re.split("\s+or\s+", match.group(1).strip("? \t"))	33 choices = self.question_delim_regexp.split(match.group(1).strip("? \t"))

35 if len(choices) > 1:	34 if len(choices) > 1:

36 self.say_public(channel, "%s: %s" % (sender, random.choice(choices)))	35 self.say_public(channel, "%s: %s" % (sender, random.choice(choices)))

37	36

38 def say_public(self, channel, text):	37 def say_public(self, channel, text):

39 self.queue.send(text, channel)	38 self.queue.send(text, channel)

LEFT	RIGHT