Issue 2377 - Implement user filter lists toggle

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 164 matching lines @@
       case "app.listen":
         if (message.filter)
           listenerFilters.app = message.filter;
         else
           delete listenerFilters.app;
         break;
       case "app.open":
         if (message.what == "options")
           ext.showOptions();
         break;
+      case "app.userSubscriptionsToggle":

[Thomas Greiner, 2016/03/01 12:11:22]

Please reuse "subscriptions.toggle" for that because that's what it's meant for.
You can introduce a `downloadable: true|false` option as in "subscriptions.get"
to differentiate between toggling of downloadable and user subscriptions.

+        var subscriptions = FilterStorage.subscriptions;
+        for (var i = 0; i < subscriptions.length; i++)
+        {
+          if (subscriptions[i] instanceof SpecialSubscription)
+            subscriptions[i].disabled = message.state;

[Thomas Greiner, 2016/03/01 12:11:22]

It's a "toggle" function so it should toggle the state, not set it.

+        }
+        FilterNotifier.triggerListeners("app.userSubscriptionsToggle", 

[Thomas Greiner, 2016/03/01 12:11:22]

We already have a filter event for that: "subscription.disabled" (see
"subscriptions.toggle" below)

+          message.state);
+        break;
       case "filters.add":
         var filter = Filter.fromText(message.text);
         var result = require("filterValidation").parseFilter(message.text);
         if (result.error)
           sendMessage("app", "error", [result.error.toString()], sender.page);
         else if (result.filter)
           FilterStorage.addFilter(result.filter);
         break;
       case "filters.blocked":
         var filter = defaultMatcher.matchesAny(message.url, message.requestType,
@@ skipping 168 matching lines @@
           if (subscription instanceof DownloadableSubscription)
             Synchronizer.execute(subscription, true);
         }
         break;
       case "subscriptions.isDownloading":
         callback(Synchronizer.isExecuting(message.url));
         break;
     }
   });
 })(this);