Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(738)

Issue 29337790: Issue 3676 - Configure update_issues hook (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Felix Dahlke
Modified:
4 years, 3 months ago
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

Issue 3676 - Configure update_issues hook

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M modules/hgweb/manifests/init.pp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M modules/hgweb/templates/sitescripts.ini.erb View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Felix Dahlke
4 years, 3 months ago (2016-02-26 18:35:47 UTC) #1
mathias
https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manifests/init.pp File modules/hgweb/manifests/init.pp (right): https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manifests/init.pp#newcode46 modules/hgweb/manifests/init.pp:46: $trac_abpbot_password = hiera('hgweb::abpbot_password', 'abpbot'), Please ensure the $hgweb::parameter being ...
4 years, 3 months ago (2016-02-26 18:41:59 UTC) #2
mathias
https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/templates/sitescripts.ini.erb File modules/hgweb/templates/sitescripts.ini.erb (right): https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/templates/sitescripts.ini.erb#newcode10 modules/hgweb/templates/sitescripts.ini.erb:10: issue_url_template=https://issues.adblockplus.org/ticket/{id} On 2016/02/26 18:41:59, mathias wrote: > Why are ...
4 years, 3 months ago (2016-02-26 18:45:56 UTC) #3
Felix Dahlke
New patch set is up. https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manifests/init.pp File modules/hgweb/manifests/init.pp (right): https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manifests/init.pp#newcode46 modules/hgweb/manifests/init.pp:46: $trac_abpbot_password = hiera('hgweb::abpbot_password', 'abpbot'), ...
4 years, 3 months ago (2016-02-26 18:53:16 UTC) #4
mathias
4 years, 3 months ago (2016-02-26 19:03:17 UTC) #5
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5