Unified Diff: pages/subscriptions.tmpl
Issue 29337807:
Issue 3097 - Refactored subscriptions list table on adblockplus.org/en/subscriptions (Closed)
Patch Set: Changed table into unordered list, refactored list markup, refactored main css and templates to support multiple footer elements
Created Feb. 27, 2016, 4:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« includes/subscriptionList.tmpl ('K')
|
« includes/subscriptionList.tmpl ('k')
|
static/css/main.css » ('j')
|
static/css/main.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: pages/subscriptions.tmpl |
| diff --git a/pages/subscriptions.tmpl b/pages/subscriptions.tmpl |
| index ba97537c5a94e10303bb5f8a45b9ba25ba14924f..bc519e0554ab64fc7d38e939cd9f1c57b2d8185a 100644 |
| --- a/pages/subscriptions.tmpl |
| +++ b/pages/subscriptions.tmpl |
| @@ -18,29 +18,69 @@ title=Known Adblock Plus subscriptions |
| <style type="text/css"> |
| -.subscriptions |
| +.subscriptions-list, |
| +.supplemented-subscriptions-list |
| { |
| - border-collapse: collapse; |
| - width: 100%; |
| + margin: 0; |
|
Thomas Greiner
2016/07/15 16:07:54
Coding style: "CSS number values should specify un
juliandoucette
2016/07/19 22:29:17
Done.
|
| + list-style: none; |
| } |
| -.subscriptions td |
| +.subscriptions-list |
| { |
| - width: 50%; |
| + padding: 0; |
| +} |
| + |
| +.supplemented-subscriptions-list |
| +{ |
| + padding-left: 30px; |
|
Thomas Greiner
2016/07/15 16:07:54
Please avoid using "border/margin/padding-bottom/l
juliandoucette
2016/07/19 22:29:17
I hadn't considered rtl when I created this patch.
|
| } |
| -.subscriptions td, .subscriptions th |
| +.subscription |
| +{ |
| + position: relative; |
| + overflow: auto; |
| + /* Using outline and margin instead of border to prevent overlapping |
| + and missing connections in hirarchy */ |
|
Thomas Greiner
2016/07/15 16:07:54
Typo: Replace "hirarchy" with "hierarchy".
juliandoucette
2016/07/19 22:29:17
Thanks! :)
|
| + outline: 1px dashed #000; |
| + margin-left: -1px; |
| + margin-top: 1px; |
| +} |
| + |
| +.subscription h1 |
| +{ |
| + margin: 0; |
| + font-size: 16px; |
| +} |
| + |
| +.subscription p |
| +{ |
| + margin: 0; |
| +} |
| + |
| +.subscription-summary, |
| +.subscription-authors, |
| +.subscription-links |
| { |
| - vertical-align: top; |
| - border: 1px dashed black; |
| padding: 5px; |
| } |
| -.subscriptions .dummy |
| +.subscription-content, |
| +.subscription-details |
| +{ |
| + float: left; |
| + width: 50%; |
| +} |
| + |
| + |
| +.subscription-authors, |
| +.subscription-links |
| +{ |
| + border-left: 1px dashed #000; |
| +} |
| + |
| +.subscription-links |
| { |
| - border-style: none; |
| - width: 20px; |
| - min-width: 20px; |
| + border-top: 1px dashed #000; |
| } |
| .subscriptions .deprecated |
« includes/subscriptionList.tmpl ('K')
|
« includes/subscriptionList.tmpl ('k')
|
static/css/main.css » ('j')
|
static/css/main.css » ('J')
