Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/default.tmpl

Issue 29337807: Issue 3097 - Refactored subscriptions list table on adblockplus.org/en/subscriptions (Closed)
Patch Set: Refactored markup & styles, added rtl styles, and fixed typo. Created July 19, 2016, 10:26 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: templates/default.tmpl
===================================================================
--- a/templates/default.tmpl
+++ b/templates/default.tmpl
@@ -138,17 +138,17 @@
{% endif %}
{% endif %}
{% block body %}
{{body|safe}}
{% endblock %}
</div>
- <footer>
+ <footer class="footer-main">
Thomas Greiner 2016/07/27 09:42:10 Detail: What about using an ID instead? Because it
juliandoucette 2016/07/27 12:11:01 I did that habitually based on csslint rules http:
Thomas Greiner 2016/07/27 13:25:49 It's a discussion that we probably need to have in
juliandoucette 2016/07/28 21:34:01 Done.
<div id="footer-content">
<nav>
<section class="first">
<h1>{{get_string("resources", "menu")}}</h1>
<ul>
{% for name in ["acceptable-ads", "documentation", "deployments", "privacy", "impressum"] %}
{{pageitem(name)}}
{% endfor %}

Powered by Google App Engine
This is Rietveld