src/Notification.cpp - Issue 29337850: Issue 3724 - Add JsValue::Call(const JsValue&)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/Notification.cpp

Issue 29337850: Issue 3724 - Add JsValue::Call(const JsValue&) (Closed)

Patch Set: Created March 3, 2016, 10:49 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/Notification.cpp

diff --git a/src/Notification.cpp b/src/Notification.cpp

index 89bd10e144379a7fa3503cb0fd57ca352c07eb89..0b1b2f7d6c79083438dd663b0d24a71f75f35edc 100644

--- a/src/Notification.cpp

+++ b/src/Notification.cpp

@@ -67,11 +67,9 @@ NotificationType Notification::GetType() const

return StringToNotificationType(GetProperty("type")->AsString());

}

-NotificationTexts Notification::GetTexts()

+NotificationTexts Notification::GetTexts() const

{

- JsValueList params;

- params.push_back(shared_from_this());

- JsValuePtr jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(params);

+ JsValuePtr jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(*this);

NotificationTexts notificationTexts;

JsValuePtr jsTitle = jsTexts->GetProperty("title");

if (jsTitle->IsString())

@@ -105,7 +103,5 @@ std::vector<std::string> Notification::GetLinks() const

void Notification::MarkAsShown()

{

- JsValueList params;

- params.push_back(GetProperty("id"));

- jsEngine->Evaluate("API.markNotificationAsShown")->Call(params);

+ jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id"));

}

« no previous file with comments | « src/JsValue.cpp ('k') | test/JsValue.cpp » ('j') | no next file with comments »