Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29337873: Issue 3729 - Make "Block element" dialog adapt to variable window sizes (Closed)

Created:
March 3, 2016, 2:13 p.m. by Sebastian Noack
Modified:
March 3, 2016, 5:44 p.m.
Reviewers:
saroyanm
CC:
Wladimir Palant, Thomas Greiner, kzar
Visibility:
Public.

Description

Issue 3729 - Make "Block element" dialog adapt to variable window sizes

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M block.html View 1 2 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
March 3, 2016, 2:14 p.m. (2016-03-03 14:14:00 UTC) #1
saroyanm
https://codereview.adblockplus.org/29337873/diff/29337874/block.html File block.html (right): https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42 block.html:42: font-family: Arial, Helvetica, sans-serif; Detail: Can you please reorder ...
March 3, 2016, 3:29 p.m. (2016-03-03 15:29:25 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29337873/diff/29337874/block.html File block.html (right): https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42 block.html:42: font-family: Arial, Helvetica, sans-serif; On 2016/03/03 15:29:25, saroyanm wrote: ...
March 3, 2016, 3:40 p.m. (2016-03-03 15:40:14 UTC) #3
saroyanm
LGTM https://codereview.adblockplus.org/29337873/diff/29337874/block.html File block.html (right): https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42 block.html:42: font-family: Arial, Helvetica, sans-serif; On 2016/03/03 15:40:14, Sebastian ...
March 3, 2016, 4:11 p.m. (2016-03-03 16:11:34 UTC) #4
Sebastian Noack
March 3, 2016, 5:42 p.m. (2016-03-03 17:42:33 UTC) #5
https://codereview.adblockplus.org/29337873/diff/29337874/block.html
File block.html (right):

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42
block.html:42: font-family: Arial, Helvetica, sans-serif;
On 2016/03/03 16:11:34, saroyanm wrote:
> On 2016/03/03 15:40:14, Sebastian Noack wrote:
> > On 2016/03/03 15:29:25, saroyanm wrote:
> > > Detail: Can you please reorder css properties with the order specified in
> the
> > > https://adblockplus.org/en/coding-style 
> > 
> > Done, I think.
> 
> Yes only one small note: please move display properties on top.

I did leave the display property definition below as it is flex-box related,
which I think is also kinda inline with that WordPress article which states to
group similar properties.

Powered by Google App Engine
This is Rietveld