Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 29337881: Issue 3574 - Move workaround for #3479 from class base to adblockplus (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by mathias
Modified:
3 years, 4 months ago
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3574 - Move workaround for #3479 from class base to adblockplus

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 3574 - Move development RSA keys to module adblockplus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -40 lines) Patch
A + modules/adblockplus/files/development_host_rsa_key View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + modules/adblockplus/files/development_host_rsa_key.pub View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M modules/adblockplus/manifests/init.pp View 1 1 chunk +14 lines, -0 lines 0 comments Download
D modules/base/files/development_host_rsa_key View 1 1 chunk +0 lines, -27 lines 0 comments Download
D modules/base/files/development_host_rsa_key.pub View 1 1 chunk +0 lines, -1 line 0 comments Download
M modules/base/manifests/init.pp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5
mathias
3 years, 4 months ago (2016-03-06 19:32:58 UTC) #1
Fred
https://codereview.adblockplus.org/29337881/diff/29337882/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29337881/diff/29337882/modules/adblockplus/manifests/init.pp#newcode53 modules/adblockplus/manifests/init.pp:53: source => 'puppet:///modules/base/development_host_rsa_key', Shouldn't we also change the file ...
3 years, 4 months ago (2016-03-07 12:11:30 UTC) #2
mathias
3 years, 4 months ago (2016-03-07 14:13:16 UTC) #3
mathias
https://codereview.adblockplus.org/29337881/diff/29337882/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29337881/diff/29337882/modules/adblockplus/manifests/init.pp#newcode53 modules/adblockplus/manifests/init.pp:53: source => 'puppet:///modules/base/development_host_rsa_key', On 2016/03/07 12:11:29, Fred wrote: > ...
3 years, 4 months ago (2016-03-07 14:13:53 UTC) #4
Fred
3 years, 4 months ago (2016-03-07 14:18:59 UTC) #5
On 2016/03/07 14:13:53, mathias wrote:
>
https://codereview.adblockplus.org/29337881/diff/29337882/modules/adblockplus...
> File modules/adblockplus/manifests/init.pp (right):
> 
>
https://codereview.adblockplus.org/29337881/diff/29337882/modules/adblockplus...
> modules/adblockplus/manifests/init.pp:53: source =>
> 'puppet:///modules/base/development_host_rsa_key',
> On 2016/03/07 12:11:29, Fred wrote:
> > Shouldn't we also change the file source to the adblockplus module then?
> 
> Acknowledged.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5