Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: globals/get_subscriptions.py

Issue 29337941: Issue 3750 - Avoid re-generating subscription list for each locale (Closed)
Left Patch Set: Created March 8, 2016, 3:27 p.m.
Right Patch Set: Turned get_subscriptions into a global function Created March 9, 2016, 3:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « filters/get_subscriptions.py ('k') | pages/subscriptions.tmpl » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 # This file is part of the Adblock Plus website, 1 # This file is part of the Adblock Plus website,
2 # Copyright (C) 2006-2016 Eyeo GmbH 2 # Copyright (C) 2006-2016 Eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details. 11 # GNU General Public License for more details.
12 # 12 #
13 # You should have received a copy of the GNU General Public License 13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15 15
16 import codecs 16 import codecs
17 import os 17 import os
18 import tarfile 18 import tarfile
19 import urllib 19 import urllib
20 import logging 20 import logging
21 from ConfigParser import SafeConfigParser 21 from ConfigParser import SafeConfigParser
22 22
23 def get_subscriptions(_): 23 subscriptions = None
24
25 def get_subscriptions():
26 global subscriptions
27 if not subscriptions is None:
28 return subscriptions
24 try: 29 try:
25 from sitescripts.subscriptions import subscriptionParser 30 from sitescripts.subscriptions import subscriptionParser
26 except ImportError: 31 except ImportError:
27 logging.warning("Unable to import sitescripts, proceeding with empty " 32 logging.warning("Unable to import sitescripts, proceeding with empty "
28 "subscriptions list.") 33 "subscriptions list.")
29 return [] 34 return []
30 35
31 result = {} 36 result = {}
32 utf8_reader = codecs.getreader('utf8') 37 utf8_reader = codecs.getreader('utf8')
33 source = urllib.urlopen("https://hg.adblockplus.org/subscriptionlist/archive/d efault.tar.gz") 38 source = urllib.urlopen("https://hg.adblockplus.org/subscriptionlist/archive/d efault.tar.gz")
(...skipping 16 matching lines...) Expand all
50 filedata = subscriptionParser.parse_file(fileinfo.name, utf8_reader(arch ive.extractfile(fileinfo))) 55 filedata = subscriptionParser.parse_file(fileinfo.name, utf8_reader(arch ive.extractfile(fileinfo)))
51 if filedata.unavailable: 56 if filedata.unavailable:
52 continue 57 continue
53 58
54 result[filedata.name] = filedata 59 result[filedata.name] = filedata
55 finally: 60 finally:
56 source.close() 61 source.close()
57 subscriptionParser.get_settings = orig_get_settings 62 subscriptionParser.get_settings = orig_get_settings
58 63
59 subscriptionParser.calculate_supplemented(result) 64 subscriptionParser.calculate_supplemented(result)
60 return result.values() 65 subscriptions = result.values()
66 return subscriptions
LEFTRIGHT

Powered by Google App Engine
This is Rietveld