Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(400)

Issue 29337967: Issue 3760 - Merged Chrome and Opera builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Sebastian Noack
Modified:
3 years, 11 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 3760 - Merged Chrome and Opera builds

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated README file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M README.md View 1 3 chunks +6 lines, -9 lines 0 comments Download
M _locales/en_US/messages.json View 1 chunk +2 lines, -8 lines 0 comments Download
R metadata.opera View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
3 years, 11 months ago (2016-03-08 17:03:39 UTC) #1
kzar
https://codereview.adblockplus.org/29337967/diff/29337968/_locales/en_US/messages.json File _locales/en_US/messages.json (left): https://codereview.adblockplus.org/29337967/diff/29337968/_locales/en_US/messages.json#oldcode33 _locales/en_US/messages.json:33: "description_chrome": { As string names have changed I guess ...
3 years, 11 months ago (2016-03-08 17:44:46 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29337967/diff/29337968/_locales/en_US/messages.json File _locales/en_US/messages.json (left): https://codereview.adblockplus.org/29337967/diff/29337968/_locales/en_US/messages.json#oldcode33 _locales/en_US/messages.json:33: "description_chrome": { On 2016/03/08 17:44:46, kzar wrote: > As ...
3 years, 11 months ago (2016-03-08 17:46:47 UTC) #3
kzar
Oh yea, LGTM
3 years, 11 months ago (2016-03-08 17:49:27 UTC) #4
Sebastian Noack
Yeah, always that pesky README file. ;) Mind checking my changes there?
3 years, 11 months ago (2016-03-08 18:24:09 UTC) #5
kzar
3 years, 11 months ago (2016-03-08 18:43:45 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5