Issue 3758 - Removed Opera Extensions related logic

sitescripts/extensions/utils.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import codecs
 import os
 import json
 import re
 import subprocess
 import time
 import urlparse
 import urllib
-import urllib2
 import xml.dom.minidom as dom
 from ConfigParser import SafeConfigParser, NoOptionError
 from StringIO import StringIO
 from sitescripts.utils import get_config
 
+PACKAGE_SUFFIXES = {
+  'gecko': '.xpi',
+  'chrome': '.crx',
+  'safari': '.safariextz',
+  'ie': '.exe',
+  'android': '.apk'
+}
+
 def compareVersionParts(part1, part2):
   def convertInt(value, default):
     try:
       return int(value)
     except ValueError:
       return default
 
   def convertVersionPart(part):
     if part == '*':
       # Special case - * is interpreted as Infinity
@@ skipping 114 matching lines @@
 
     self.repositoryName = repositoryName
     self.repository = repository
     self.config = config
     self.nightlyConfig = nightlyConfig
 
     if self.config.has_option('extensions', self.repositoryName + '_type'):
       self.type = self.config.get('extensions', self.repositoryName + '_type')
     else:
       self.type = 'gecko'
-
-    if self.type == 'gecko':
-      self.packageSuffix = '.xpi'
-    elif self.type == 'chrome' or self.type == 'opera':
-      self.packageSuffix = '.crx'
-    elif self.type == 'safari':
-      self.packageSuffix = '.safariextz'
-    elif self.type == 'ie':
-      self.packageSuffix = '.exe'
-    elif self.type == 'android':
-      self.packageSuffix = '.apk'
+    self.packageSuffix = PACKAGE_SUFFIXES[self.type]
 
     if self.nightlyConfig and not self.nightlyConfig.has_section(self.repositoryName):
       self.nightlyConfig.add_section(self.repositoryName)
 
   def __str__(self):
     """
       Provides a string representation of this configuration
     """
     return self.repositoryName
 
@@ skipping 73 matching lines @@
   document = dom.parse(_urlopen(url))
   linkTags = document.getElementsByTagName('install')
   linkTag = linkTags[0] if len(linkTags) > 0 else None
   versionTags = document.getElementsByTagName('version')
   versionTag = versionTags[0] if len(versionTags) > 0 else None
   if linkTag and versionTag and linkTag.firstChild and versionTag.firstChild:
     return (linkTag.firstChild.data, versionTag.firstChild.data)
   else:
     return (None, None)
 
-def _getGoogleDownloadLink(galleryID):

[Sebastian Noack, 2016/03/08 17:23:05]

For reference, the web store URLs are hard-coded on adblockplus.org meanwhile.
And the mechanism here is only used anymore for extensions hosted on our server.

-  """
-  gets download link for a Chrome add-on from the Chrome Gallery site
-  """
-  galleryID = _urlencode(galleryID)
-
-  url = 'https://clients2.google.com/service/update2/crx?x=%s' % _urlencode('id=%s&uc' % galleryID)
-  document = dom.parse(_urlopen(url))
-  updateTags = document.getElementsByTagName('updatecheck')
-  version = updateTags and updateTags[0].getAttribute('version')
-
-  if not version:
-    return (None, None)
-
-  request = urllib2.Request('https://chrome.google.com/webstore/detail/_/' + galleryID)
-  request.get_method = lambda : 'HEAD'
-  url = urllib2.urlopen(request).geturl()
-
-  return (url, version)
-
-def _getOperaDownloadLink(galleryID):
-  """
-  gets download link for an Opera add-on from the Opera Addons site
-  """
-  galleryID = _urlencode(galleryID)
-
-  request = urllib2.Request('https://addons.opera.com/extensions/download/%s/' % galleryID)
-  request.get_method = lambda : 'HEAD'
-  response = urllib2.urlopen(request)
-
-  content_disposition = response.info().getheader('Content-Disposition')
-  if content_disposition:
-    match = re.search(r'filename=\S+-([\d.]+)-\d+\.crx$', content_disposition)
-    if match:
-      return ('https://addons.opera.com/extensions/details/%s/' % galleryID , match.group(1))
-
-  return (None, None)
-
 def _getLocalLink(repo):
   """
   gets the link for the newest download of an add-on in the local downloads
   repository
   """
   highestURL = None
   highestVersion = None
 
   for filename, version in repo.getDownloads():
     if not highestVersion or compareVersions(version, highestVersion) > 0:
       highestURL = urlparse.urljoin(repo.downloadsURL, filename)
       highestVersion = version
 
   return (highestURL, highestVersion)
 
 def _getDownloadLink(repo):
   """
   gets the download link to the most current version of an extension
   """
-  if repo.galleryID:
-    if repo.type == "chrome":
-      return _getGoogleDownloadLink(repo.galleryID)
-    elif repo.type == "opera":
-      return _getOperaDownloadLink(repo.galleryID)
-    elif repo.type == "gecko":
-      return _getMozillaDownloadLink(repo.galleryID)
-
+  if repo.galleryID and repo.type == "gecko":
+    return _getMozillaDownloadLink(repo.galleryID)
   return _getLocalLink(repo)
 
 def _getQRCode(text):
   try:
     import qrcode
     import base64
     import Image    # required by qrcode but not formally a dependency
   except:
     return None
 
@@ skipping 63 matching lines @@
   if not extensions:
     return
 
   updates = {}
   for extension in extensions:
     updates[extension['basename']] = {
       "url": extension['updateURL'],
       "version": extension['version']
     }
   writeLibabpUpdateManifest(path, updates)