Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338009: Issue 3763 - Got rid of redundant "add-filters" message type (Closed)

Created:
March 9, 2016, 8:30 a.m. by Sebastian Noack
Modified:
March 9, 2016, 6:12 p.m.
Reviewers:
kzar
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 3763 - Got rid of redundant "add-filters" message type

Patch Set 1 #

Patch Set 2 : Update adblockplusui dependency #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M background.js View 1 chunk +0 lines, -14 lines 0 comments Download
M block.js View 1 chunk +5 lines, -5 lines 0 comments Download
M dependencies View 1 1 chunk +1 line, -1 line 4 comments Download

Messages

Total messages: 6
Sebastian Noack
March 9, 2016, 8:31 a.m. (2016-03-09 08:31:17 UTC) #1
kzar
https://codereview.adblockplus.org/29338009/diff/29338019/dependencies File dependencies (left): https://codereview.adblockplus.org/29338009/diff/29338019/dependencies#oldcode6 dependencies:6: adblockplusui = adblockplusui hg:49ac049b2b2f git:b845b0d This dependency update is ...
March 9, 2016, 4:58 p.m. (2016-03-09 16:58:27 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29338009/diff/29338019/dependencies File dependencies (left): https://codereview.adblockplus.org/29338009/diff/29338019/dependencies#oldcode6 dependencies:6: adblockplusui = adblockplusui hg:49ac049b2b2f git:b845b0d On 2016/03/09 16:58:27, kzar ...
March 9, 2016, 5:12 p.m. (2016-03-09 17:12:12 UTC) #3
kzar
https://codereview.adblockplus.org/29338009/diff/29338019/dependencies File dependencies (left): https://codereview.adblockplus.org/29338009/diff/29338019/dependencies#oldcode6 dependencies:6: adblockplusui = adblockplusui hg:49ac049b2b2f git:b845b0d On 2016/03/09 17:12:11, Sebastian ...
March 9, 2016, 5:15 p.m. (2016-03-09 17:15:51 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29338009/diff/29338019/dependencies File dependencies (left): https://codereview.adblockplus.org/29338009/diff/29338019/dependencies#oldcode6 dependencies:6: adblockplusui = adblockplusui hg:49ac049b2b2f git:b845b0d On 2016/03/09 17:15:51, kzar ...
March 9, 2016, 5:36 p.m. (2016-03-09 17:36:23 UTC) #5
kzar
March 9, 2016, 6:06 p.m. (2016-03-09 18:06:19 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld