Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338027: Issue 3687 - Add string for content blocking option (Closed)

Created:
March 9, 2016, 4:30 p.m. by kzar
Modified:
March 9, 2016, 5:17 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3687 - Add string for content blocking option

Patch Set 1 #

Patch Set 2 : Renamed string, removed strong tag and put in order #

Total comments: 1

Patch Set 3 : Renamed string again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M _locales/en_US/messages.json View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
March 9, 2016, 4:30 p.m. (2016-03-09 16:30:59 UTC) #1
kzar
Patch Set 2 : Renamed string, removed strong tag and put in order
March 9, 2016, 4:52 p.m. (2016-03-09 16:52:08 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29338027/diff/29338032/_locales/en_US/messages.json File _locales/en_US/messages.json (right): https://codereview.adblockplus.org/29338027/diff/29338032/_locales/en_US/messages.json#newcode113 _locales/en_US/messages.json:113: "options_safariContentBlocker": { Nit: With the semantics in the file ...
March 9, 2016, 5:04 p.m. (2016-03-09 17:04:31 UTC) #3
kzar
Patch Set 3 : Renamed string again
March 9, 2016, 5:14 p.m. (2016-03-09 17:14:06 UTC) #4
Sebastian Noack
March 9, 2016, 5:15 p.m. (2016-03-09 17:15:30 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld