Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(673)

Issue 29338096: Issue 3783 - Redirect auth page to review after upload (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Wladimir Palant
Modified:
4 years, 1 month ago
Reviewers:
Sebastian Noack
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3783 - Redirect auth page to review after upload

Patch Set 1 #

Total comments: 3

Patch Set 2 : Don't inherit globals #

Total comments: 2

Patch Set 3 : Try different ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -6 lines) Patch
M hgreview.py View 1 2 3 chunks +60 lines, -6 lines 0 comments Download

Messages

Total messages: 7
Wladimir Palant
4 years, 2 months ago (2016-03-10 14:14:26 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29338096/diff/29338097/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338096/diff/29338097/hgreview.py#newcode86 hgreview.py:86: execfile(upload_path, scope) Side-effect of using execfile rather than subprocess.call: ...
4 years, 2 months ago (2016-03-10 14:17:19 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29338096/diff/29338097/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338096/diff/29338097/hgreview.py#newcode86 hgreview.py:86: execfile(upload_path, scope) Wow, downloading and executing code from the ...
4 years, 2 months ago (2016-03-10 14:30:20 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29338096/diff/29338097/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338096/diff/29338097/hgreview.py#newcode86 hgreview.py:86: execfile(upload_path, scope) On 2016/03/10 14:30:20, Sebastian Noack wrote: > ...
4 years, 2 months ago (2016-03-10 14:52:18 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29338096/diff/29338105/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338096/diff/29338105/hgreview.py#newcode84 hgreview.py:84: port = random.randrange(2000, 60000) I'm not sure whether it's ...
4 years, 2 months ago (2016-03-10 15:08:23 UTC) #5
Wladimir Palant
https://codereview.adblockplus.org/29338096/diff/29338105/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338096/diff/29338105/hgreview.py#newcode84 hgreview.py:84: port = random.randrange(2000, 60000) On 2016/03/10 15:08:22, Sebastian Noack ...
4 years, 2 months ago (2016-03-11 10:12:42 UTC) #6
Sebastian Noack
4 years, 2 months ago (2016-03-11 14:57:37 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5