Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338144: Issue 3779, issue 3784 - Make sure review description isn't cut off and contains repository path (Closed)

Created:
March 11, 2016, 2:13 p.m. by Wladimir Palant
Modified:
March 11, 2016, 3:07 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3779, issue 3784 - Make sure review description isn't cut off and contains repository path Repository: hg.adblockplus.org/codingtools/

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M hgreview.py View 1 chunk +25 lines, -4 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
March 11, 2016, 2:13 p.m. (2016-03-11 14:13:21 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py#newcode68 hgreview.py:68: match = re.search(r'^(?:https://|ssh://hg@)(.*)', path); No plain HTTP?
March 11, 2016, 2:56 p.m. (2016-03-11 14:56:22 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py#newcode68 hgreview.py:68: match = re.search(r'^(?:https://|ssh://hg@)(.*)', path); On 2016/03/11 14:56:22, Sebastian Noack ...
March 11, 2016, 3:03 p.m. (2016-03-11 15:03:53 UTC) #3
Sebastian Noack
March 11, 2016, 3:04 p.m. (2016-03-11 15:04:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld