Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 29338144: Issue 3779, issue 3784 - Make sure review description isn't cut off and contains repository path (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Wladimir Palant
Modified:
3 years, 10 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3779, issue 3784 - Make sure review description isn't cut off and contains repository path Repository: hg.adblockplus.org/codingtools/

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M hgreview.py View 1 chunk +25 lines, -4 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 10 months ago (2016-03-11 14:13:21 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py#newcode68 hgreview.py:68: match = re.search(r'^(?:https://|ssh://hg@)(.*)', path); No plain HTTP?
3 years, 10 months ago (2016-03-11 14:56:22 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338144/diff/29338145/hgreview.py#newcode68 hgreview.py:68: match = re.search(r'^(?:https://|ssh://hg@)(.*)', path); On 2016/03/11 14:56:22, Sebastian Noack ...
3 years, 10 months ago (2016-03-11 15:03:53 UTC) #3
Sebastian Noack
3 years, 10 months ago (2016-03-11 15:04:15 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5