Issue 3780 - wait for the loading of filters and only afterwards start to fetch pages

lib/crawler.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 /**
  * @module crawler
  */
 
@@ skipping 198 matching lines @@
  */
 function run(window, urls, timeout, maxtabs, targetURL, onDone)
 {
   new Promise((resolve, reject) =>
   {
     if (FilterStorage.subscriptions.length > 0)
     {
       resolve();
       return;
     }
-    FilterNotifier.addListener((action, item, newValue, oldValue) =>

[Wladimir Palant, 2016/03/15 14:50:58]

Just realized: you have to remove that listener after it fires.

[sergei, 2016/03/15 14:58:45]

Acknowledged.

+    let onFiltersLoaded = (action, item, newValue, oldValue) =>
     {
       if (action == "load")
       {
+        FilterNotifier.removeListener(onFiltersLoaded);
         resolve();
       }
-    });
-  }).then(() => crawl_urls(window, urls, timeout, maxtabs, targetURL, onDone)).catch(reportException);

[Wladimir Palant, 2016/03/15 14:50:58]

Sorry but now having catch() on the same line no longer makes sense - the line
got too long...

[sergei, 2016/03/15 14:58:45]

Done.

+    };
+    FilterNotifier.addListener(onFiltersLoaded);
+  }).then(() => crawl_urls(window, urls, timeout, maxtabs, targetURL, onDone))
+  .catch(reportException);
 }
 exports.run = run;
 
 /**
  * Spawns a {Task} task to crawl each url from `urls` argument and calls
  * `onDone` when all tasks are finished.
  * @param {Window} window
  *   The browser window we're operating in
  * @param {String[]} urls
  *   URLs to be crawled
@@ skipping 116 matching lines @@
 
 function reportException(e)
 {
   let stack = "";
   if (e && typeof e == "object" && "stack" in e)
     stack = e.stack + "\n";
 
   Cu.reportError(e);
   dump(e + "\n" + stack + "\n");
 }