.gitignore - Issue 29338156: Issue 3754 - Initial setup of the python-abp repo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .gitignore

Issue 29338156: Issue 3754 - Initial setup of the python-abp repo. (Closed)

Left Patch Set: Created March 11, 2016, 5:13 p.m.

Right Patch Set: Remove pytest from qa dependencies in tox.ini, change "filterlist" to "filter list" Created March 17, 2016, 2:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 */.pyc	1 *.pyc

2 .cache	2 *.pyo
Sebastian Noack 2016/03/14 11:16:00 I think we should only ignore those folders at the I think we should only ignore those folders at the top-level: /.cache/ /.coverage/ /.tox/ Vasily Kuznetsov 2016/03/14 12:04:28 Acknowledged. Show quoted text On 2016/03/14 11:16:00, Sebastian Noack wrote: > I think we should only ignore those folders at the top-level: > > /.cache/ > /.coverage/ > /.tox/ Acknowledged.
3 .coverage	3 __pycache__

4 .tox	4 /.coverage

5 __	5 /.cache/
Sebastian Noack 2016/03/14 11:16:01 What is this entry about? What is this entry about? Vasily Kuznetsov 2016/03/14 12:04:28 This is a virtualenv that the makefile creates. It Show quoted text On 2016/03/14 11:16:01, Sebastian Noack wrote: > What is this entry about? This is a virtualenv that the makefile creates. It's used for testing and other things during development. Sebastian Noack 2016/03/14 12:19:22 Is it common practice to call it __, or should we Show quoted text On 2016/03/14 12:04:28, Vasily Kuznetsov wrote: > On 2016/03/14 11:16:01, Sebastian Noack wrote: > > What is this entry about? > > This is a virtualenv that the makefile creates. It's used for testing and other > things during development. Is it common practice to call it __, or should we rather give a more descriptive name to it? Vasily Kuznetsov 2016/03/14 17:20:41 The only special thing about naming it __ is that Show quoted text On 2016/03/14 12:19:22, Sebastian Noack wrote: > On 2016/03/14 12:04:28, Vasily Kuznetsov wrote: > > On 2016/03/14 11:16:01, Sebastian Noack wrote: > > > What is this entry about? > > > > This is a virtualenv that the makefile creates. It's used for testing and > other > > things during development. > > Is it common practice to call it __, or should we rather give a more descriptive > name to it? The only special thing about naming it __ is that when the virtualenv is activated, the shell prompt prefix becomes [python-abp] (by the name of the parent directory, that is working copy root). However, it seems that the virtualenv is not really used like this very much, so perhaps a more descriptive name would be better. How about I just call it "devenv"?
6 python_abp.egg-info	6 /.tox/
Sebastian Noack 2016/03/14 11:16:00 I'd rather avoid duplicating the project name. Als I'd rather avoid duplicating the project name. Also it seems to be sufficient as well to only consider the top-level here: /.egg-info Vasily Kuznetsov* 2016/03/14 12:04:28 Acknowledged. Show quoted text On 2016/03/14 11:16:00, Sebastian Noack wrote: > I'd rather avoid duplicating the project name. Also it seems to be sufficient as > well to only consider the top-level here: > > /*.egg-info Acknowledged.
	7 /dist/

	8 /devenv/

	9 /*.egg-info

LEFT	RIGHT