README.md - Issue 29338156: Issue 3754 - Initial setup of the python-abp repo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29338156: Issue 3754 - Initial setup of the python-abp repo. (Closed)

Left Patch Set: Address review comments (LICENSE.txt -> COPYING, .gitignore, encoding, license headers in empty fil… Created March 15, 2016, 11:24 a.m.

Right Patch Set: Remove pytest from qa dependencies in tox.ini, change "filterlist" to "filter list" Created March 17, 2016, 2:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # python-abp	1 # python-abp

2	2

3 A library for working with Adblock Plus filterlists.	3 A library for working with Adblock Plus filter lists

4	4

5 ## Copyright and license	5 ## Testing
Sebastian Noack 2016/03/15 12:18:07 For our other projects we don't have a license dis For our other projects we don't have a license disclaimer in the README. Vasily Kuznetsov 2016/03/15 13:14:35 Makes sense. With COPYING file at the top level it Show quoted text On 2016/03/15 12:18:07, Sebastian Noack wrote: > For our other projects we don't have a license disclaimer in the README. Makes sense. With COPYING file at the top level it's reasonably redundant.
6	6

7 `python-abp` is part of [AdblockPlus](https://adblockplus.org/).	7 Unit tests for `python-abp` are located in the `/tests` directory.

8 Copyright (C) 2006-2016 Eyeo GmbH.	8 [Pytest](http://pytest.org/) is used for quickly running the tests

	9 during development.

	10 [Tox](https://tox.readthedocs.org/) is used for testing in different

	11 environments (Python 2.7, Python 3.5 and PyPy) and code quality

	12 reporting.

9	13

10 Adblock Plus is free software: you can redistribute it and/or modify	14 In order to execute the tests, first create and activate development

11 it under the terms of the GNU General Public License version 3 as	15 virtualenv:

12 published by the Free Software Foundation.

13	16

14 Adblock Plus is distributed in the hope that it will be useful,	17 $ python setup.py devenv

15 but WITHOUT ANY WARRANTY; without even the implied warranty of	18 $ . devenv/bin/activate

16 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

17 GNU General Public License for more details.

18	19

19 You should have received a copy of the GNU General Public License	20 With the development virtualenv activated use pytest for a quick test run:

20 along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	21

	22 (devenv) $ py.test tests

	23

	24 and tox for a comprehensive report:

	25

	26 (devenv) $ tox

LEFT	RIGHT