Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/ext/background.js

Issue 29338187: Issue 3696 - Fall back to tabs.create if windows.create isn't available (Closed)
Left Patch Set: Created March 14, 2016, 7:53 a.m.
Right Patch Set: Check only existence, not the type Created March 14, 2016, 9:32 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 ext.pages.open(optionsUrl, callback); 587 ext.pages.open(optionsUrl, callback);
588 } 588 }
589 }); 589 });
590 }); 590 });
591 }; 591 };
592 592
593 /* Windows */ 593 /* Windows */
594 ext.windows = { 594 ext.windows = {
595 create: function(createData, callback) 595 create: function(createData, callback)
596 { 596 {
597 if (typeof chrome.windows.create === "function"){ 597 if ("create" in chrome.windows){
Sebastian Noack 2016/03/14 08:28:17 Nit; it should be sufficient to check for existenc
598 chrome.windows.create(createData, function(createdWindow) 598 chrome.windows.create(createData, function(createdWindow)
599 { 599 {
600 afterTabLoaded(callback)(createdWindow.tabs[0]); 600 afterTabLoaded(callback)(createdWindow.tabs[0]);
601 }); 601 });
602 } 602 }
603 else 603 else
604 { 604 {
605 ext.pages.open(createData.url, callback); 605 ext.pages.open(createData.url, callback);
606 } 606 }
607 } 607 }
608 }; 608 };
609 })(); 609 })();
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld