Issue 3696 - Fall back to tabs.create if windows.create isn't available

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 576 matching lines @@
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
 
   /* Windows */
   ext.windows = {
     create: function(createData, callback)
     {
-      if (typeof chrome.windows.create === "function"){

[Sebastian Noack, 2016/03/14 08:28:17]

Nit; it should be sufficient to check for existence, instead for type. That is
how we check for optional APIs all over the place:

  "create" in chrome.windows

+      if ("create" in chrome.windows){
         chrome.windows.create(createData, function(createdWindow)
         {
             afterTabLoaded(callback)(createdWindow.tabs[0]);
         });
       }
       else
       {
         ext.pages.open(createData.url, callback);          
       }
     }
   };
 })();