dependencies - Issue 29338190: Issue 3697 - Fall back to i18n.getUILanguage if @ui_locale isn't supported

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: dependencies

Issue 29338190: Issue 3697 - Fall back to i18n.getUILanguage if @ui_locale isn't supported (Closed)

Patch Set: Update the adblockplusui dependency. Add a comment. Change regexp. Created Aug. 29, 2017, 1:34 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:0234926280f1 git:48bb35a	3 buildtools = buildtools hg:0234926280f1 git:48bb35a

4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447	4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447

5 adblockpluscore = adblockpluscore hg:442aa536668a git:65f427d	5 adblockpluscore = adblockpluscore hg:442aa536668a git:65f427d

6 adblockplusui = adblockplusui hg:9976daa84915 git:1ec5c0d	6 adblockplusui = adblockplusui hg:104a61b1949d git:e691a7d
	kzar 2017/08/29 16:17:24 This includes a whole bunch of unrelated changes b This includes a whole bunch of unrelated changes but they're not listed in the issue. Have you checked through them all to make sure nothing else is being broken / needs to be re-tested by QA? Sebastian Noack 2017/08/29 16:47:46 The vast majority of these changes only effect the Show quoted text On 2017/08/29 16:17:24, kzar wrote: > This includes a whole bunch of unrelated changes but they're not listed in the > issue. Have you checked through them all to make sure nothing else is being > broken / needs to be re-tested by QA? The vast majority of these changes only effect the new options page. When comparing the build after this update, the only unrelated changes I see are setLinks() being moved from firstRun.js to common.js, some whitespace changes, and the changes to the copyright header. Oleksandr 2017/08/30 09:19:12 I have also updated the ticket to list the importe Show quoted text On 2017/08/29 16:47:46, Sebastian Noack wrote: > On 2017/08/29 16:17:24, kzar wrote: > > This includes a whole bunch of unrelated changes but they're not listed in the > > issue. Have you checked through them all to make sure nothing else is being > > broken / needs to be re-tested by QA? > > The vast majority of these changes only effect the new options page. When > comparing the build after this update, the only unrelated changes I see are > setLinks() being moved from firstRun.js to common.js, some whitespace changes, > and the changes to the copyright header. I have also updated the ticket to list the imported changes. As Sebastian said, most of the work done in adblockplusui seems to be on the new-options page. We can probably add a hint to testers to test if all the links work, but other than that this import is a minor one.
OLD	NEW

« no previous file with comments | « no previous file | lib/notificationHelper.js » ('j') | lib/utils.js » ('J')