Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338201: Issue 3719 - Adapt for changes in the initilization code on Chrome/Safari (Closed)

Created:
March 14, 2016, 11:55 a.m. by Sebastian Noack
Modified:
March 15, 2016, 2:04 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3719 - Adapt for changes in the initilization code on Chrome/Safari

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M README.md View 1 chunk +2 lines, -2 lines 0 comments Download
M firstRun.html View 1 chunk +0 lines, -1 line 0 comments Download
M firstRun.js View 1 chunk +0 lines, -10 lines 0 comments Download
M locale/en-US/firstRun.json View 2 chunks +1 line, -4 lines 0 comments Download
M messageResponder.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
March 14, 2016, 11:56 a.m. (2016-03-14 11:56:03 UTC) #1
Thomas Greiner
LGTM assuming that we are confident that the data corruption issue is not an issue ...
March 14, 2016, 4:58 p.m. (2016-03-14 16:58:40 UTC) #2
Sebastian Noack
March 14, 2016, 5:09 p.m. (2016-03-14 17:09:05 UTC) #3
On 2016/03/14 16:58:40, Thomas Greiner wrote:
> LGTM assuming that we are confident that the data corruption issue is not an
> issue anymore.

As far as I can tell, scenarios where a data corruption would have been detected
but filter lists wouldn't reinitlize was not possible anymore. So with the
platform changes this patch depends on, the related logic has been gone. Note
that if there are no filters we reinitilize anyway, showing the first run page
with the respective message.

Powered by Google App Engine
This is Rietveld