Issue 3810 - Remove hardcoded default mirror list from Malware Domains List conversion script

sitescripts/subscriptions/bin/updateMalwareDomainsList.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 24 matching lines @@
     response = urllib2.urlopen(mirror + MALWAREDOMAINS_PATH)
     return response.read()
   except urllib2.HTTPError:
     return None
 
 
 if __name__ == '__main__':
   config = get_config()
   section = 'subscriptionDownloads'
   repository = config.get(section, 'malwaredomains_repository')
-  mirrors_list = config.get(section, 'malwaredomains_mirrors').split()

[Sebastian Noack, 2016/03/16 11:27:34]

I guess we can call this variable simply "mirrors" now.

[Vasily Kuznetsov, 2016/03/16 11:56:59]

And then later we'll have "for mirror in mirrors", yeah, that's nicer indeed.

+  mirrors = config.get(section, 'malwaredomains_mirrors').split()
 
   tempdir = tempfile.mkdtemp(prefix='malwaredomains')
   try:
     subprocess.check_call(['hg', '-q', 'clone',  '-U', repository, tempdir])
     subprocess.check_call(['hg', '-q', 'up', '-R', tempdir, '-r', 'default'])
 
     path = os.path.join(tempdir, 'malwaredomains_full.txt')
     file = codecs.open(path, 'wb', encoding='utf-8')
 
     print >>file, FILTERLIST_HEADER
 
-    for mirror in mirrors_list:
+    for mirror in mirrors:
       data = try_mirror(mirror)
       if data is not None:
         break
     else:
       sys.exit('Unable to fetch malware domains list.')
 
     zip = zipfile.ZipFile(StringIO(data), 'r')
     info = zip.infolist()[0]
     for line in str(zip.read(info.filename)).splitlines():
       domain = line.strip()
       if not domain:
         continue
 
       print >>file, '||%s^' % domain.decode('idna')
     file.close();
 
     if subprocess.check_output(['hg', 'stat', '-R', tempdir]) != '':
       subprocess.check_call(['hg', '-q', 'commit', '-R', tempdir, '-A', '-u', 'hgbot', '-m', 'Updated malwaredomains.com data'])
       subprocess.check_call(['hg', '-q', 'push', '-R', tempdir])
   finally:
     shutil.rmtree(tempdir, ignore_errors=True)